-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a safer Resource.attempt
which releases acquired resource(s) in case of error
#4128
base: series/3.x
Are you sure you want to change the base?
Commits on Sep 2, 2024
-
Implement a safer Resource.attempt, fix typelevel#3757
Which releases acquired resource(s) in case of error and `MonadCancelThrow` constrain is required in order to do that. This also take away implicit `ApplicativeError` and deprecated the current attempt method.
Configuration menu - View commit details
-
Copy full SHA for 8d16f92 - Browse repository at this point
Copy the full SHA 8d16f92View commit details
Commits on Sep 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 07fa387 - Browse repository at this point
Copy the full SHA 07fa387View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2839446 - Browse repository at this point
Copy the full SHA 2839446View commit details -
Implement handleErrorWith with MonadCancelThrow
Deprecated handleErrorWith with ApplicativeError
Configuration menu - View commit details
-
Copy full SHA for 3c2d6af - Browse repository at this point
Copy the full SHA 3c2d6afView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb1a293 - Browse repository at this point
Copy the full SHA cb1a293View commit details
Commits on Sep 7, 2024
-
Best effort to improve deprecated attempt
Fix F is `Sync`, We know that it has to be a `MonadCancelThrow`, therefore We can use safer attempt and `unsafely` cast the result.
Configuration menu - View commit details
-
Copy full SHA for 3b7d0ee - Browse repository at this point
Copy the full SHA 3b7d0eeView commit details -
Deprecate catsEffectMonadErrorForResource
Also remove implicit modifier from it.
Configuration menu - View commit details
-
Copy full SHA for 206020c - Browse repository at this point
Copy the full SHA 206020cView commit details
Commits on Sep 8, 2024
-
Apply suggestions from code review
Co-authored-by: Arman Bilge <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cd729a5 - Browse repository at this point
Copy the full SHA cd729a5View commit details -
Revert implicit for Resource MonadError instance
MonadCancelThrow instance (which is required for the fixed attempt) is already higher priority than this one. By leaving it implicit, users will get an actionable deprecation instead of non-compiling code.
Configuration menu - View commit details
-
Copy full SHA for f00b9cd - Browse repository at this point
Copy the full SHA f00b9cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40cb12a - Browse repository at this point
Copy the full SHA 40cb12aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 840514d - Browse repository at this point
Copy the full SHA 840514dView commit details -
Co-authored-by: Arman Bilge <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6bda660 - Browse repository at this point
Copy the full SHA 6bda660View commit details