Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows compatibility #120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Windows compatibility #120

wants to merge 2 commits into from

Conversation

zner0L
Copy link
Contributor

@zner0L zner0L commented Aug 25, 2023

No description provided.

@zner0L zner0L requested a review from baltpeter August 25, 2023 14:26
@zner0L zner0L marked this pull request as draft August 25, 2023 14:26
@zner0L zner0L marked this pull request as ready for review August 28, 2023 11:14
@zner0L
Copy link
Contributor Author

zner0L commented Aug 28, 2023

I tested iOS and Android physical devices in a Windows 10 VM, successfully. I did not test emulators, bc they don’t work in my VM.

@baltpeter
Copy link
Member

I tested on a physical laptop with Windows 11 22H2.

  • examples/android-device.ts worked fine.
  • I wasn't able to try examples/android-emulator.ts. After creating an emulator with andromatic, I wasn't able to start that (Emulators don't work on Windows andromatic#9).
  • examples/ios-device.ts did not work for me. Without a device connected, it comes up with the "You need to connect your device." error after longer than I would expect. But if I connect a device, nothing happens. I just appears to hang. I waited for more than 20 minutes with no change. I did accept the trust prompt on the phone.

@baltpeter
Copy link
Member

Actually, it does work on my iOS 15 iPhone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baltpeter baltpeter Awaiting requested review from baltpeter

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zner0L @baltpeter