Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot and bracket notation 2 #268

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

abdulredd
Copy link
Contributor

@abdulredd abdulredd commented Sep 10, 2024

❗️This PR does not need to be merged immediately and can be placed on the back burner to focus on more pressing things.

Curriculum PR Template

Does this PR close any issues?

#188

This PR aims to convert 2 lessons from FE1 and FE2. This is the conversion of FE2's lesson.

Description

Not many updates in this one. I decided to omit any Ruby references, so this is 98% the same lesson as before. In my opinion, this lesson doesn't include anything [I don't think] that the first lesson didn't. For this, I think this second lesson could probably be sunset safely.

Changes include:

  • Converting the lesson from live to async (removing language surrounding live work)

What questions do you have/what do you want feedback on? (optional)

  • With the changes to Replit, should we consider moving the exercises into the SE2 "big" repo?
    • There is 1 Repl
      There were a bunch of instructor comments that I left there, not sure if they should be removed or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant