Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #1100

Open
wants to merge 148 commits into
base: main
Choose a base branch
from
Open

Code cleanup #1100

wants to merge 148 commits into from

Conversation

jimmacur
Copy link

@jimmacur jimmacur commented Aug 4, 2024

General code clean up:

  • all hashes have the same formatting
  • remove all pseudocode
  • eliminate extra spaces
  • standardize file formatting to have 4 spaces be the default tab setting
  • put all methods at the top in the order of iteration 2 request and all helper methods at the bottom
  • edit tabs to all be correctly aligned

CCirbo and others added 30 commits July 29, 2024 17:04
@CCirbo
Initial commit with the start of spec_helper
7a58206
@CCirbo
Adds functional gemfile
dcd2752
@CCirbo
Adds gitignore
f75991b
@CCirbo
Initial commit adds class and test files
c8f3709
@CCirbo
Fixes spec_helper and game spec files
080a23f
@Sgalvin36
Merge pull request #1 from CCirbo/simplecove/setup
b2b4d6a 
Simplecove/setup
@Sgalvin36
Add initial test and functionality
82cedea
@stefanjbloom
Initial branch commit
c0b0678
@stefanjbloom
Feat: attr reader and initialize setup
c7a8d4c
@CPPittman
adds basic structure to teamsclass file and initializes class
9f4a4a4
@stefanjbloom
Feat/Test instance variables created
c4ed640
@CPPittman
adds method to team spec file and adds a runner file
5e1a481
@Sgalvin36
Add framework for CSV reader
014f70f
@stefanjbloom
Readme updated w/ deliv, contrib and org tools
b5b2618
@Sgalvin36
Add outline for each class_factory method
712c44b
@CCirbo
Feat/adds initial tests
624a8a8
@stefanjbloom
Merge pull request #2 from CCirbo/teams/team_class
cb75cfa 
Teams/team class.  Both Shane and Stefan have eyes on this merge.
@CCirbo
Feat/adds initialize to game team class
3129f2d
@jimmacur
Merge pull request #3 from CCirbo/game/game_spec
836a285 
Game/game spec
@jimmacur
Merge pull request #4 from CCirbo/game-team/setup
54e07f1 
Game team/setup
@Sgalvin36
Merge branch 'main' of github.com:CCirbo/futbol into stat_tracker
484f53c
@Sgalvin36
pulled classes into project
a1a1c0d
@Sgalvin36
Pass from_csv test
172e800
@Sgalvin36
Add test to ensure games are being instantiated
4b198f8
@Sgalvin36
Add team and game_team verification tests
7047cd2
@Sgalvin36
Add instance test to see all variables filled in
db41653
@Sgalvin36
Add instance test to see all variables filled in for teams
7727a74
@CCirbo
Feat/adds dummy csv files
b34f8fc
@Sgalvin36
Add game_team_factory test to validate variables being filled
030b0c7
@jimmacur
Merge pull request #5 from CCirbo/stat_tracker
4a4bc93 
Stat tracker
jimmacur and others added 30 commits August 2, 2024 15:10
@jimmacur
fixes team spec to match atrributes
74ca980
@jimmacur
fixes game team spec test to match class attributes
91e260d
@jimmacur
fixes stat tracker spec team factory tests
fe9ef07
@CPPittman
added best offense method and updated test
69f06b9
@stefanjbloom
Merge pull request #18 from CCirbo/refactor_main_classes
1147c9b 
Refactor main classes
@CPPittman
added worst offense method and updated the test
06319e4
@Sgalvin36
Merge pull request #19 from CCirbo/league_statistics_offense_methods
d384d25 
League statistics offense methods
@CCirbo
Feat/adds method highest scoring visitor
7792b0b
@CCirbo
Feat/adds lowest scoring home team
f8f081a
@CCirbo
Feat/adds lowest scoring visitor method
814cd43
@CCirbo
Feat/refactored methods and added a helper method
30e279a
@CCirbo
Test/adds finished tests for methods
09b96dc
@Sgalvin36
Worked through all skipped tests to verify passing correctly
02cd213
@Sgalvin36
Adjusted a few variables in GameStat
436ab5c
@Sgalvin36
Refactor best and worst offense to get another helper method
6ffd09a
@CCirbo
Feat/adds all deliverables to the Readme
a0831ca
@Sgalvin36
Merge pull request #20 from CCirbo/league/helper-methods
4f4087e 
League/helper methods
@Sgalvin36
Merge branch 'main' of github.com:CCirbo/futbol into refactor_and_add…
3faf918 
…_helpers
@Sgalvin36
Refactor all methods for team_goals_and_games into one method
48a3b96
@Sgalvin36
Refactor goals_per_game methods into single method
57826aa
@Sgalvin36
Refactored several methods to use get_team_name method
987ac8f
@Sgalvin36
Add tests for helper methods
dda639e
@Sgalvin36
Add goals_per_game test
5479852
@Sgalvin36
Refactor test to create objects in before-all instead of before-each …
697af7d 
…to speed up testing
@Sgalvin36
Refactor teams class object
3655d48
@Sgalvin36
Refactor game_teams class
8e92d51
@Sgalvin36
Refactor game class
1f56f7f
@CCirbo
Merge pull request #21 from CCirbo/refactor_and_add_helpers
1cd14ff 
Refactor and add helpers
@jimmacur
file cleanup-tabs, hashes, order, spaces, ends
c8f3a5f
@jimmacur
final touches to cleanup
4245441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jimmacur @CCirbo @Sgalvin36 @stefanjbloom @CPPittman