Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/readme #1096

Open
wants to merge 146 commits into
base: main
Choose a base branch
from
Open

Update/readme #1096

wants to merge 146 commits into from

Conversation

jchirch
Copy link

@jchirch jchirch commented Aug 2, 2024

includes notes on our project retro into readme

jchirch and others added 30 commits July 29, 2024 20:20
@jchirch
Initial commit
7dc2792
@jphill19
Add: gemfile
fd61c3e
@jphill19
Add: spec_helper.rb
eb21b4b
@jchirch
Merge pull request #10 from kylomite/gemfile
f3db8d6 
Gemfile
@bwillett2003
Merge pull request #11 from kylomite/feat/README-firstdraft
3687f48 
Initial commit
@jphill19
Feat: add simplecov require & .gitignore
d7bd802
@jchirch
Merge pull request #12 from kylomite/gemfile
90f9923 
Feat: add simplecov require & .gitignore
@kylomite
feat- set up structure for StatTracker
4ca7fc7
@kylomite
feat- add game class
0548ae2
@kylomite
refactor- add dummy csvs
6bc3405
@kylomite
feat complete game IO set up
87e6879
@jchirch
feat: team class
e05c64f
@SThompson05
Feat: season class set up
7b05ab4
@jphill19
Feat: added GameStatistics class
263bcf8
@SThompson05
Merge pull request #28 from kylomite/feat/fileIO
fcf3b99 
file IO
@jphill19
test: add init tests
a2c88e5
@jphill19
test: add init test for Season & Team
a3fa3e5
@jphill19
test: add stat_tracker tests
7231222
@jchirch
Merge pull request #34 from kylomite/refactor/fileIO_tests
2cbc4c3 
Refactor/file io tests
@bwillett2003
feat:completed highest_total_score and helper method.
250d1c2
@kylomite
Merge pull request #38 from kylomite/feat/#highest_total_score
2bfa0b2 
feat:completed highest_total_score and helper method.
@jphill19
refactor: removed GameStatistics class, and incorporated into StatTra…
0666d90 
…cker
@kylomite
Merge pull request #39 from kylomite/refactor/stat_tracker
818a83c 
refactor: removed GameStatistics class, and incorporated into StatTra…
@jchirch
test: percentage home wins test suite
c42f197
@jchirch
feat: percentage home wins method
c3cb8bc
@jchirch
refactor: relocated methods after data readers
5113817
@jchirch
test: best offense test suite
6b89feb
@kylomite
refactor: move highest total score test
361334e
@bwillett2003
Merge pull request #40 from kylomite/feat/#percentage_home_wins
9b93b3d 
Feat/#percentage home wins
@bwillett2003
Merge pull request #41 from kylomite/refactor/layout
c0a9fd1 
refactor: relocated methods after data readers
jchirch and others added 30 commits August 4, 2024 16:31
@jchirch
refactor: worst coach helper methods
3949a18
@jchirch
test: win loss ratio test suite
a18226b
@jphill19
Refactor: Refactored fewest tackles and added helper methods
9862baf
@jphill19
Refacot: removed commented code
700dd1b
@jphill19
Test: added team_tackles_in_games test
7e27b0d
@jchirch
test: id to coach test suite
c710da3
@jchirch
Merge pull request #66 from kylomite/refactor/fewest_tackles
e0de869 
Refactor/fewest tackles
@bwillett2003
Merge branch 'main' into feat/#worst_coach
0403dcd
@bwillett2003
Merge pull request #67 from kylomite/feat/#worst_coach
f1189e4 
Feat/#worst coach
@bwillett2003
refactor: Removed commented code for rspec test that already exists.
c2276fe
@bwillett2003
refactor: Removed more commented code for rspec that already exists.
36b99ab
@bwillett2003
refactor: Relocated winninest_coach method to be in line with worst_c…
d2a4863 
…oach
@kylomite
refactor: least_accurate_team to use helper methods
175fd24
@bwillett2003
feat: winningest_coach method created using worst_coach helper methods.
0b9be1d
@kylomite
refactor: highest_scoring_visitor to use helper methods
bae75ef
@bwillett2003
test: winningest_coach rspec test.
ff1ea0f
@bwillett2003
refactor: corrected indentation between id_to_name and worst_offense.
fb3a4b6
@bwillett2003
refactor: corrected indentation worst_offense and highest_scoring_vis…
6eced62 
…itor.
@bwillett2003
corrected more indentation between methods.
1ed5814
@kylomite
Merge pull request #70 from kylomite/feat/winningest_coach
02d05dd 
Feat/winningest coach
@SThompson05
feat: most_tackles completed with tests
96866c1
@SThompson05
Merge pull request #68 from kylomite/refactor/least_accurate_team
37064e0 
refactor: least_accurate_team to use helper methods
@SThompson05
Merge pull request #69 from kylomite/refactor/highest_scoring_visitor
f7b010c 
refactor: highest_scoring_visitor to use helper methods
@jphill19
Merge pull request #71 from kylomite/feat/most_tackles
7973634 
Feat/most tackles
@bwillett2003
refactor: Removed commented code.
5a47a45
@bwillett2003
refactor: Removed commented code and improved white space.
cdeb1be
@kylomite
Merge pull request #72 from kylomite/refactor/stat_tracker_spec
b80a944 
Refactor/stat tracker spec
@bwillett2003
refactor: updating README.
ed98651
@bwillett2003
refactor: Updated LinkedIn URL
8fb792e
@bwillett2003
docs: Completed README
9af995b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jchirch @jphill19 @bwillett2003 @kylomite @SThompson05