-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karl/stat tracker 2 #1084
Open
SmilodonP
wants to merge
83
commits into
turingschool-examples:main
Choose a base branch
from
CoryBretsch:karl/stat_tracker_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Karl/stat tracker 2 #1084
SmilodonP
wants to merge
83
commits into
turingschool-examples:main
from
CoryBretsch:karl/stat_tracker_2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_tracker file. Created a spec_helper file to hold SimpleCov. Installed Simplecov Gem.
copied/pasted James code, added README.md project requirements
fixed gitignore
…r league initialize method.
added Team class and spec that turns teams.csv into data objects
…game_spec, and the initialize in the game.rb
…es instead of a hash. rewrote games_spec to correspond to games being instances.
adding game_teams class and spec with test data file
James game class
… pull data from the games.csv.
created games_test.csv for easier testing. Passing games_spec test to…
…of home wins, percentage of visitor wins and percentage of ties. Created matching methods for each test.
…racker_connection no message necessary
Cory/stat tracker connection
…s. Also added before(:each) block in stat_tracker_spec to clean things up
adding high/low scoring away team with tests. passes with spec_harnes…
adding highest/lowest scoring home team with test. Spec harness passes
James season branch
Cory/most fewest tackles
Karl/stat tracker
James season branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in all of the most recent work I did after fixing some merge issues