Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

James game class #1071

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
6eaa8c8
created runner file with the code provided in iteration. Created Sta…
James-Cochran Jun 4, 2024
36cea67
copied/pasted James code, added README.md project requirements
CoryBretsch Jun 4, 2024
5e19c86
Merge pull request #1 from CoryBretsch/cory/set_up
SmilodonP Jun 4, 2024
f656314
corrected merge conflicts
James-Cochran Jun 4, 2024
1901b29
Update README.md
CoryBretsch Jun 4, 2024
713727d
Update README.md
CoryBretsch Jun 4, 2024
66fd83a
Update .gitignore
SmilodonP Jun 4, 2024
b52fd31
created league.rb and league_spec.rb files. started the first test f…
James-Cochran Jun 4, 2024
04e2c4b
added Team class and spec that turns teams.csv into data objects
CoryBretsch Jun 4, 2024
1bf7cd0
Merge branch 'main' into cory/read_teams_data
James-Cochran Jun 4, 2024
4fe0669
Merge pull request #2 from CoryBretsch/cory/read_teams_data
James-Cochran Jun 4, 2024
34ecf5a
corrected typo in league_spec and added csv require ot league
James-Cochran Jun 4, 2024
4c327f9
resolved merge conflict in spec_helper.rb
James-Cochran Jun 4, 2024
572c7b2
created game.rb file and game_spec file. created initial hash in the…
James-Cochran Jun 4, 2024
d35c105
filled out the last 2 questions in README
SmilodonP Jun 5, 2024
2e39e25
adding game_teams class and spec with test data file
CoryBretsch Jun 5, 2024
51d6254
corrected game.rb file to games.rb. rewrote games class to be instan…
James-Cochran Jun 5, 2024
e13ace6
Merge pull request #4 from CoryBretsch/cory/read_game_teams_data
James-Cochran Jun 5, 2024
211b0db
started test for games_spec to verify it is pulling from CSV
James-Cochran Jun 5, 2024
44651ae
Merge branch 'main' into james_game_class
CoryBretsch Jun 5, 2024
6817afb
Merge pull request #5 from CoryBretsch/james_game_class
CoryBretsch Jun 5, 2024
3f2f5a5
created games_test.csv for easier testing. Passing games_spec test to…
James-Cochran Jun 5, 2024
c80c5d0
Merge pull request #6 from CoryBretsch/james_game_class
SmilodonP Jun 5, 2024
0e2b497
Update README.md
CoryBretsch Jun 6, 2024
c2da976
passing test for highest total score, lowest total score, percentage …
James-Cochran Jun 6, 2024
a9d836e
YAY
CoryBretsch Jun 6, 2024
1fa987d
Merge branch 'main' of github.com:CoryBretsch/futbol into cory/stat_t…
CoryBretsch Jun 6, 2024
2b18048
Merge pull request #7 from CoryBretsch/cory/stat_tracker_connection
SmilodonP Jun 6, 2024
0dccedd
passing test and method for count of games by season.
James-Cochran Jun 6, 2024
2037353
passing average goals per game with accompanying method
James-Cochran Jun 6, 2024
3f1eb3d
passing test with method for average goals by season.
James-Cochran Jun 6, 2024
fe238f3
resolved merge conflict.
James-Cochran Jun 6, 2024
c43f907
moved all games_statistics methods into stat_tracker. Adjusted games…
James-Cochran Jun 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
coverage

7 changes: 7 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
source 'https://rubygems.org'

gem 'simplecov', require: false, group: :test

group :development, :test do
gem 'rspec'
end
34 changes: 34 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
GEM
remote: https://rubygems.org/
specs:
diff-lcs (1.5.1)
docile (1.4.0)
rspec (3.13.0)
rspec-core (~> 3.13.0)
rspec-expectations (~> 3.13.0)
rspec-mocks (~> 3.13.0)
rspec-core (3.13.0)
rspec-support (~> 3.13.0)
rspec-expectations (3.13.0)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-mocks (3.13.1)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.1)
simplecov (0.22.0)
docile (~> 1.1)
simplecov-html (~> 0.11)
simplecov_json_formatter (~> 0.1)
simplecov-html (0.12.3)
simplecov_json_formatter (0.1.4)

PLATFORMS
arm64-darwin-23

DEPENDENCIES
rspec
simplecov

BUNDLED WITH
2.4.10
38 changes: 37 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,39 @@
# Futbol

Starter repository for the [Turing School](https://turing.io/) Futbol project.

# CONTRIBUTORS
Karl Fallenius
- insert github profile
- insert LinkedIn profile

James Cochran
- insert github profile
- insert LinkedIn profile

Cory Bretsch
- [GitHub Profile](https://github.com/CoryBretsch)
- insert LinkedIn profile


# README REQUIREMENTS
### DTR - Mon. June 3rd, 2024
[Link to DTR](https://docs.google.com/document/d/1FACITYUJOXfrlqmo62Xsbf1nut_gJ6O829bR0uazS5U/edit)
- Initial DTR Completed June 3rd, 2024
- Re-DTR Planned for June 6th, 2024
- Retro Planned for June 7th, 2024

### CHECK-IN PLAN
- We plan to conduct daily stand-ups 5 min before class. We will complete our first retro and Re-DTR on thursday, June 6th during the class-scheduled time.

### PROJECT ORGANIZATION AND WORKFLOW
- We will be using an [EasyRetro](https://easyretro.io/publicboard/YEugqgDd8JcsiJopBf4DhiOR6Cm2/5bc57278-d612-429a-8138-c199ea17cebd) Kanban board to help organize tasks.
- We will follow a branch naming convention of 'person_first_name/feature_working_on'. An example is 'James/highest_total_score'.
- We will require 1 person to review code and merge a PR

### APPROACHES TO PROJECT ORGANIZATION
- We looked at a variety of different project management tools and approaches before deciding a kanban board would fit our needs the best, and easyretro would be an excellent tool for implementation. So far it seems to be working really well for us.

### APPROACH TO CODE DESIGN
- We discussed a number of different code design approaches. A great example is whether to work with data ojects being pulled from the CSVs by using hashes and assigning values as instance variables, or alternatively, skipping the hash step and treating the data objects as individual objects with their own attributes. We decided to go with the latter option. Our goal is to keep everything as simple and straight forward as we possibly can.

We will be using TDD, as well as "red, green, refactor" to establish functionality.
212 changes: 212 additions & 0 deletions coverage/.resultset.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,212 @@
{
"RSpec": {
"coverage": {
"/Users/jamescochran/mod1/projects/futbol/lib/stat_tracker.rb": {
"lines": [
1,
1,
1,
null,
1,
1,
null,
1,
8,
8,
8,
null,
null,
1,
0,
0,
0,
null,
0,
null,
null,
1,
11,
null,
null,
1,
11,
null,
null,
1,
1,
11,
1,
null,
null,
1,
1,
11,
1,
null,
null,
1,
1,
11,
1,
null,
null,
1,
0,
0,
0,
null,
0,
null,
null,
1,
1,
11,
1,
null,
null,
1,
1,
1,
1,
10,
10,
null,
null,
1,
1,
1,
null,
1,
null,
null,
null,
null,
null
]
},
"/Users/jamescochran/mod1/projects/futbol/lib/game_teams.rb": {
"lines": [
1,
null,
1,
1,
null,
null,
null,
null,
null,
null,
null,
null,
null,
null,
null,
null,
null,
null,
null,
1,
133,
133,
133,
133,
133,
133,
133,
133,
133,
133,
133,
133,
133,
133,
133,
null,
null,
1,
7,
7,
133,
null,
7,
null,
null,
null
]
},
"/Users/jamescochran/mod1/projects/futbol/lib/games.rb": {
"lines": [
1,
null,
1,
1,
null,
null,
null,
null,
null,
null,
null,
null,
null,
null,
1,
null,
70,
70,
70,
70,
70,
70,
70,
70,
70,
70,
null,
null,
1,
7,
7,
70,
null,
7,
null,
null
]
},
"/Users/jamescochran/mod1/projects/futbol/lib/teams.rb": {
"lines": [
1,
null,
1,
1,
null,
null,
null,
null,
null,
null,
1,
224,
224,
224,
224,
224,
224,
null,
null,
1,
7,
7,
224,
null,
7,
null,
null,
null
]
}
},
"timestamp": 1717791252
}
}
File renamed without changes.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions coverage/assets/0.12.3/application.css

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions coverage/assets/0.12.3/application.js

Large diffs are not rendered by default.

Binary file added coverage/assets/0.12.3/colorbox/border.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added coverage/assets/0.12.3/colorbox/controls.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added coverage/assets/0.12.3/colorbox/loading.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added coverage/assets/0.12.3/favicon_green.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added coverage/assets/0.12.3/favicon_red.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added coverage/assets/0.12.3/favicon_yellow.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added coverage/assets/0.12.3/loading.gif
Binary file added coverage/assets/0.12.3/magnify.png
Loading