Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass simplecov #1037

Open
wants to merge 108 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
108 commits
Select commit Hold shift + click to select a range
ad78246
test
n0rdie Nov 7, 2023
8ada2b9
Merge pull request #1 from n0rdie/inital_README
LoganFinnegan Nov 7, 2023
bb8e60c
Merge pull request #2 from n0rdie/simplecov_setup
megroth2 Nov 7, 2023
7a1921c
DTR README.md
n0rdie Nov 7, 2023
4a16e1f
simplecov setup
n0rdie Nov 7, 2023
c738eef
inital stat_tracker
n0rdie Nov 7, 2023
9b429f7
Merge pull request #3 from n0rdie/stat_tracker_class_and_spec
megroth2 Nov 7, 2023
24a5d24
add empty files
LoganFinnegan Nov 7, 2023
5bfda31
Merge pull request #4 from n0rdie/added_files
n0rdie Nov 7, 2023
e957bb6
innitial team spec tests
n0rdie Nov 7, 2023
5ba125e
added Excel spreadsheet to README.md
n0rdie Nov 7, 2023
c48ebd5
team class initialze
n0rdie Nov 7, 2023
c715a24
fixed initalize misspell
n0rdie Nov 7, 2023
fd8e262
small bug fixes
n0rdie Nov 7, 2023
bb37228
Merge pull request #5 from n0rdie/team_spec
LoganFinnegan Nov 7, 2023
594c912
Merge pull request #6 from n0rdie/team_lib
LoganFinnegan Nov 7, 2023
0ff15ed
Merge pull request #7 from n0rdie/teams_spec
LoganFinnegan Nov 7, 2023
7f55bf2
Merge pull request #8 from n0rdie/teams_lib
LoganFinnegan Nov 7, 2023
f2c2c1b
Merge pull request #11 from n0rdie/teams_spec
LoganFinnegan Nov 7, 2023
56967ee
Merge pull request #12 from n0rdie/games_spec
LoganFinnegan Nov 7, 2023
bfe3493
teams spec testing done
n0rdie Nov 7, 2023
994b78c
teams class
n0rdie Nov 7, 2023
f01fb50
game_spec initialize
n0rdie Nov 7, 2023
1eb721c
game_lib
n0rdie Nov 7, 2023
b31364c
Merge pull request #9 from n0rdie/game_lib
LoganFinnegan Nov 7, 2023
83a4ca2
forgot an s
n0rdie Nov 8, 2023
7482914
games_spec initial
n0rdie Nov 8, 2023
d891cfc
games_lib initial
n0rdie Nov 8, 2023
ad4f642
Merge pull request #13 from n0rdie/games_lib
LoganFinnegan Nov 7, 2023
b696641
game teams tests and class
LoganFinnegan Nov 8, 2023
0216bbb
add team commit
LoganFinnegan Nov 8, 2023
e18469b
Merge pull request #14 from n0rdie/game_teams
s2an Nov 8, 2023
3881c4c
teams to team_list and games to game_list
n0rdie Nov 8, 2023
56f91b9
Merge branch 'main' of github.com:n0rdie/futbol into name_changes
n0rdie Nov 8, 2023
aabbe61
Refactor to use the parse method
s2an Nov 8, 2023
c8cc19c
add a file containing a subset of data for each of 3 .csvs
megroth2 Nov 9, 2023
2fd1b41
Merge pull request #17 from n0rdie/testing/csv-subset-files
LoganFinnegan Nov 9, 2023
7e185ea
Merge pull request #16 from n0rdie/name_changes
n0rdie Nov 9, 2023
53175ef
add require_relative './helper_class' to the top of each lib file to …
megroth2 Nov 9, 2023
c957fc7
fix discrepancies and clean up initial setup files
megroth2 Nov 9, 2023
ad1e8da
Merge branch 'main' into setup-spec-harness-2
megroth2 Nov 9, 2023
8360224
Merge branch 'main' into clean-up-main
megroth2 Nov 9, 2023
1919c85
Merge pull request #20 from n0rdie/clean-up-main
megroth2 Nov 9, 2023
80dff1d
Merge branch 'collaboration-branch' of github.com:n0rdie/futbol
n0rdie Nov 9, 2023
ecf4e93
Merge pull request #19 from n0rdie/setup-spec-harness-2
megroth2 Nov 9, 2023
cc323a3
correct lib files so the spec harness will work properly
megroth2 Nov 10, 2023
40fd30d
refine spec for initialize method in game class
megroth2 Nov 10, 2023
fabc4fb
WIP: add tests for game_list methods
megroth2 Nov 10, 2023
e457411
WIP: add tests for percentage methods in game_list and stat_tracker
megroth2 Nov 10, 2023
297f1d9
fix game_spec and game_list_spec and add percentage tests to game_lis…
megroth2 Nov 10, 2023
bb9fdaa
Merge pull request #21 from n0rdie/game_team
megroth2 Nov 10, 2023
5931ee3
Merge pull request #22 from n0rdie/game-statistics/percentages
n0rdie Nov 10, 2023
be49c81
feat&test: Update files to make stat_tracker pass the spec
s2an Nov 10, 2023
a47e0ed
Merge branch 'main' into make-stat-tracker-pass
s2an Nov 10, 2023
24b62cd
Merge pull request #23 from n0rdie/make-stat-tracker-pass
megroth2 Nov 10, 2023
4c953da
add team/team_spec tests
LoganFinnegan Nov 10, 2023
bc1341e
Merge pull request #24 from n0rdie/game_team_list
megroth2 Nov 10, 2023
0566db2
Merge branch 'main' into team_and_team_list_tests
megroth2 Nov 10, 2023
9b5ed93
Merge pull request #25 from n0rdie/team_and_team_list_tests
megroth2 Nov 10, 2023
f954412
game_team test 1
n0rdie Nov 10, 2023
786a316
game_team class 1
n0rdie Nov 10, 2023
2720435
fix stat tracker and comment out simple cov
megroth2 Nov 10, 2023
3463115
add test to team list spec for create_teams method
LoganFinnegan Nov 10, 2023
8b32ef6
Update team_list_spec.rb
n0rdie Nov 10, 2023
9e147e5
Merge pull request #29 from n0rdie/team_list_tests
megroth2 Nov 10, 2023
2ffaa23
game_team_list test 1
n0rdie Nov 10, 2023
83482ea
game_team_list class 1
n0rdie Nov 10, 2023
5411aea
Merge branch 'main' into game_team_list
n0rdie Nov 10, 2023
8e6f9b7
added back in data type assigner that somehow got deleted
n0rdie Nov 10, 2023
0d4782d
Merge pull request #26 from n0rdie/fix-stat-tracker-and-comment-out-s…
n0rdie Nov 10, 2023
65b3f34
added in data type assigner that was somehow deleted
n0rdie Nov 10, 2023
4b85eec
Merge pull request #27 from n0rdie/game_team
megroth2 Nov 10, 2023
6476970
fixed list test
n0rdie Nov 10, 2023
462fdae
Merge pull request #28 from n0rdie/stat_tracker
megroth2 Nov 10, 2023
64d60ed
refactor
LoganFinnegan Nov 10, 2023
382e8fc
refactor test
LoganFinnegan Nov 10, 2023
ea95d05
add highest/lowest score methods and tests
LoganFinnegan Nov 11, 2023
5bd6b43
refactor
LoganFinnegan Nov 11, 2023
37dc946
Delete coverage/.resultset.json
LoganFinnegan Nov 11, 2023
71c7dbd
add methods to stat tracker
LoganFinnegan Nov 11, 2023
0983d9a
add highest and lowest total score tests
LoganFinnegan Nov 11, 2023
f028ac6
Merge branch 'logan' of github.com:n0rdie/futbol into logan
LoganFinnegan Nov 11, 2023
781e107
refactor
LoganFinnegan Nov 11, 2023
10c6199
refactor
LoganFinnegan Nov 11, 2023
a40b8e0
add git ignore
LoganFinnegan Nov 11, 2023
181e10f
Merge pull request #31 from n0rdie/logan2
megroth2 Nov 11, 2023
4b7048a
add count_of_games_by_season method to game_list.rb and stat_tracker.rb
megroth2 Nov 11, 2023
da981dc
add tests for highest_scoring_visitor and highest_scoring_home_team t…
megroth2 Nov 11, 2023
766b997
add tests for highest_scoring_visitor and highest_scoring_home_team t…
megroth2 Nov 11, 2023
843826a
Merge pull request #32 from n0rdie/game-statistics/count-of-games
s2an Nov 11, 2023
2820ef3
Merge pull request #33 from n0rdie/league-statistics/highest-scoring-…
s2an Nov 11, 2023
ed57038
data: Update data so x10 of each season type is included for testing
s2an Nov 12, 2023
e51b801
feat: Add most probable methods and standardize formatting
s2an Nov 12, 2023
513aca0
test: Add missing tests and notes for what needs to be checked
s2an Nov 12, 2023
cc7e6a9
Edit code for consistancy across files
s2an Nov 12, 2023
dfff15e
test: Update the before each block to make the tests more dynamic
s2an Nov 12, 2023
a495f50
edit: Correct for missing comma
s2an Nov 12, 2023
dd8a43d
refactor: Make small edits to game and overhaul spec to establish sta…
s2an Nov 12, 2023
f8c3dde
edit: Update intialize method that was missed in last edit
s2an Nov 12, 2023
e4cd741
refactor: Update verbiage and add return to count_of_games_by_season
s2an Nov 12, 2023
8492342
edit&refactor: Finish standardizing lib folder, refactored create_gam…
s2an Nov 12, 2023
3619b8b
refactor tests: Standardized x_lists spec sheets rspec tests & made n…
s2an Nov 12, 2023
b4a8d45
refactor tests: Standardize team and game_team_spec with game_spec
s2an Nov 12, 2023
022a6c3
lol: Had some chaotic good fun, probably should not merge this
s2an Nov 12, 2023
19fcaaf
feat&test: Add missing methods and game_team_test criteria
s2an Nov 12, 2023
ff727db
Merge pull request #35 from n0rdie/final-unification
megroth2 Nov 12, 2023
f205278
test: Finalize existing code with 100% simplecov coverage
s2an Nov 12, 2023
2e432dd
test: Add additional testing
s2an Nov 13, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
coverage/*
4 changes: 4 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
source 'https://rubygems.org'

gem 'rspec'
gem 'simplecov', require: false, group: :test
35 changes: 35 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
GEM
remote: https://rubygems.org/
specs:
diff-lcs (1.5.0)
docile (1.4.0)
rspec (3.12.0)
rspec-core (~> 3.12.0)
rspec-expectations (~> 3.12.0)
rspec-mocks (~> 3.12.0)
rspec-core (3.12.2)
rspec-support (~> 3.12.0)
rspec-expectations (3.12.3)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.12.0)
rspec-mocks (3.12.6)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.12.0)
rspec-support (3.12.1)
simplecov (0.22.0)
docile (~> 1.1)
simplecov-html (~> 0.11)
simplecov_json_formatter (~> 0.1)
simplecov-html (0.12.3)
simplecov_json_formatter (0.1.4)

PLATFORMS
arm64-darwin-22
arm64-darwin-23

DEPENDENCIES
rspec
simplecov

BUNDLED WITH
2.3.26
38 changes: 38 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,41 @@
# Futbol

https://docs.google.com/spreadsheets/d/1v6x85L1qvHk5-tpt0FHqZrO9v1LS5NdLgFO1EKb3h8s/edit#gid=95404790

Starter repository for the [Turing School](https://turing.io/) Futbol project.

1. A 1-2 summary or bullet points outlining your plan for check-ins throughout the duration of the project.
- We will meet again on Thursday and Sunday
- We will have daily Slack commucation.
-
2. A 2-4 sentence summary of your plan for project organization and workflow. This can include bullet points. If you plan to use a project management tool, please include a link to your project board.
- We will make sure to write the excel sheet first, followed by the test methods, followed by the code, followed by merging.
- If we do with our code should not have to touch each other at all because we will be all on the same page without having to directly compare non-spec code.
- Co-author commiting
-
3. A 2-3 sentence summary describing the different approaches your group discussed for project organization and how you collectively made a decision on which to use.
- Meg made a sick excel sheet that we will be orgainzingn our variables and methods on.
- Filling in the Excel before working on code will prevent overlap.
-
4. A 2-3 sentence summary describing your approach to the code design.
- Red-green refractor / Test then code
- Start with main class and then branch and refactor as appropriate
-
5. https://docs.google.com/document/d/1wf68IH416i1gRNfD4sSy5lah6JwIewbjMIYLxEsAAMo/edit
-
6. Create a section in your README called “Contributors”. List each group member’s name and link to their LinkedIn and Github profiles.
- Quin Nordmark
- https://github.com/n0rdie
- https://www.linkedin.com/in/quin-nordmark-28642b101/
-
- Meg Roth
- https://github.com/megroth2
- https://www.linkedin.com/in/meg-roth/
-
- Steven Nash
- https://github.com/s2an
- https://www.linkedin.com/in/stephen-nash-557b16111/
-
- Logan Finnegan
- https://github.com/LoganFinnegan
- https://www.linkedin.com/in/logan-finnegan-4728461ab/
5 changes: 5 additions & 0 deletions coverage/.last_run.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"result": {
"line": 100.0
}
}
File renamed without changes.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions coverage/assets/0.12.3/application.css

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions coverage/assets/0.12.3/application.js

Large diffs are not rendered by default.

Binary file added coverage/assets/0.12.3/colorbox/border.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added coverage/assets/0.12.3/colorbox/controls.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added coverage/assets/0.12.3/colorbox/loading.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added coverage/assets/0.12.3/favicon_green.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added coverage/assets/0.12.3/favicon_red.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added coverage/assets/0.12.3/favicon_yellow.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added coverage/assets/0.12.3/loading.gif
Binary file added coverage/assets/0.12.3/magnify.png
Loading