-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All Season Stats Methods and Tests #1000
Open
josephlee702
wants to merge
70
commits into
turingschool-examples:main
Choose a base branch
from
josephlee702:feat/more_stuff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
All Season Stats Methods and Tests #1000
josephlee702
wants to merge
70
commits into
turingschool-examples:main
from
josephlee702:feat/more_stuff
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DTR link to README.md
Feat/joseph
Test/stat tracker
…ed spec files and initialize in stat tracker class.
Implement ::from_csv by passing tests
Tests/stat tracker game_statistics
Added methods for game statistics that function with updated classes.
…ns-testing-playground
Feat/league statistics methods
Added tests for league statistics methods.
Refactor game statistic methods to remove unnecessary IVars
Feat/league stats - count of teams, best_offense, worst_offense
Wrote methods for game and season stats
Fix all errors, details in pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wrote out the methods for all of the season statistics methods and wrote the tests associated with them.