Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support bottom type as receiver #44

Closed
wants to merge 1 commit into from

Conversation

ptarjan
Copy link
Contributor

@ptarjan ptarjan commented Sep 13, 2017

I had a tough time writing a test for this since I couldn't figure out how to return the bottom type from real code

@jeffrey-s-foster
Copy link
Contributor

I'm not sure I understand this proposed change. Am I right that it makes any method call on %bot return %bot? What's the intuition behind that choice?

@ptarjan
Copy link
Contributor Author

ptarjan commented Sep 15, 2017

This was needed after #48 so that you can do foo.bar.baz. Because we typed those unknown functions as returning %bot we also made it infectious here. Should it be returning something else? If so we can use that here.

@ptarjan ptarjan changed the base branch from master to dev September 15, 2017 21:15
@jeffrey-s-foster
Copy link
Contributor

Okay to drop this in favor of #53? I like #53 much better.

@ptarjan
Copy link
Contributor Author

ptarjan commented Oct 15, 2017

+1 agreed

@ptarjan ptarjan closed this Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants