Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to javakdb 2.0 #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

migrate to javakdb 2.0 #9

wants to merge 1 commit into from

Conversation

zeddit
Copy link

@zeddit zeddit commented Aug 10, 2023

change log:

  1. change pom.xml dependency to include javakdb-2.0-BETA-1.
  2. change src/main/java/org/uwh/trino/kdb/KDBClient.java and src/main/java/org/uwh/trino/kdb/KDBType.java to import com.kx.c rather than import kx.c because javakdb-2.0 change its groupId.
  3. in src/main/java/org/uwh/trino/kdb/KDBTypes.java, change the datatypes related to datetime because javakdb-2.0 change its types.

using mvn clean package -Dmaven.test.skip to build the artifacts.
I tried to migrate the code to support trino-421, but it failed because its quite complicated to setup trino scaffold of new version.

@zeddit
Copy link
Author

zeddit commented Aug 10, 2023

for trino scaffold of new version. I found a project named trino-plugin-archetype which could create scaffold folder whose url is https://github.com/nineinchnick/trino-plugin-archetype, it manages library dependencies especially the versions, however it's also difficult to setup.

@zeddit
Copy link
Author

zeddit commented Aug 10, 2023

besides, could you please give me some advices on trino performance optimization for kdb backend. great thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant