Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate apollo 4 #2713

Merged
merged 4 commits into from
Sep 14, 2024
Merged

Migrate apollo 4 #2713

merged 4 commits into from
Sep 14, 2024

Conversation

Romakita
Copy link
Collaborator

Information

Type Breaking change
Feature Yes

Migrate the package to Apollo v4

@Romakita Romakita force-pushed the migrate-apollo-4 branch 3 times, most recently from 16f2e0e to 89151a9 Compare June 19, 2024 07:01
Copy link

Benchmarks

  • Machine: linux x64 | 4 vCPUs | 15.6GB Mem
  • Node: v18.20.3
  • Run: Wed Jun 19 2024 07:13:20 GMT+0000 (Coordinated Universal Time)
  • Method: autocannon -c 100 -d 10 -p 10 localhost:3000 (two rounds; one to warm-up, one to measure)
Version Router Requests/s Latency Throughput/Mb
koa 2.13.4 33433.6 29.39 5.96
tsed-koa 7.72.0 12016.4 82.48 10.18
express 4.19.2 10207.6 97.17 1.82
nest 8.4.3 10151.5 97.54 2.44
express-injector 4.19.2 9876.9 100.39 2.25
tsed-express 7.72.0 8773.6 112.75 1.61
express-morgan 4.19.2 5646.0 175.30 1.01
fastify-big-json 3.29.4 N/A N/A N/A
fastify-injector 3.29.4 N/A N/A N/A
fastify 3.29.4 N/A N/A N/A
nest-fastify 8.4.3 N/A N/A N/A

Explanation

The benchmark shows a performance difference between the frameworks. We note that Ts.ED is often last. In fact, Ts.ED uses features useful to a production application which reduce its performance.

For example, Ts.ED initializes a sandbox (async_hook) for each request in order to work in an isolated context if necessary.
It also initializes the elements necessary for monitoring requests in a log manager.

All this at a necessary cost that reflects the reality of a production application ;)

@Romakita Romakita force-pushed the migrate-apollo-4 branch 2 times, most recently from ab8e6c9 to 46ab4bc Compare August 4, 2024 05:17
@Romakita Romakita force-pushed the production branch 4 times, most recently from b76e7c8 to 9230a2a Compare August 25, 2024 08:18
@Romakita Romakita force-pushed the migrate-apollo-4 branch 2 times, most recently from 7d13c6c to 471f636 Compare August 29, 2024 20:12
@Romakita Romakita changed the base branch from production to alpha September 8, 2024 18:14
@Romakita Romakita force-pushed the migrate-apollo-4 branch 2 times, most recently from fb422dd to 751b518 Compare September 9, 2024 06:39
@Romakita Romakita force-pushed the migrate-apollo-4 branch 2 times, most recently from e74df8a to dec810b Compare September 12, 2024 07:26
BREAKING CHANGE: all implementation and configuration of @tsed/apollo have changed.
BREAKING CHANGE: @tsed/typegraphql use new @tsed/apollo package and support Apollo v4
@tsedio tsedio deleted a comment from github-actions bot Sep 12, 2024
@tsedio tsedio deleted a comment from github-actions bot Sep 12, 2024
@tsedio tsedio deleted a comment from github-actions bot Sep 12, 2024
@tsedio tsedio deleted a comment from github-actions bot Sep 12, 2024
@tsedio tsedio deleted a comment from github-actions bot Sep 12, 2024
@tsedio tsedio deleted a comment from github-actions bot Sep 12, 2024
@Romakita Romakita force-pushed the migrate-apollo-4 branch 3 times, most recently from 95d58a9 to 7afc1a2 Compare September 14, 2024 06:39
BREAKING CHANGE: @tsed/typegraphql use new @tsed/apollo package and support Apollo v4
@Romakita Romakita merged commit 89e0015 into alpha Sep 14, 2024
16 of 17 checks passed
@Romakita Romakita deleted the migrate-apollo-4 branch September 14, 2024 07:01
@Romakita
Copy link
Collaborator Author

🎉 This PR is included in version 8.0.0-alpha.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Romakita
Copy link
Collaborator Author

Romakita commented Oct 6, 2024

🎉 This PR is included in version 8.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant