Merge pull request #282 from niieani/fix-nested-access

fix: throw ENOTDIR when trying to open an incorrect path (nested under existing file)
tschaub · Nov 25, 2019 · 98ba9b6 · 98ba9b6
2 parents b36d90f + 9adc82f
commit 98ba9b6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/filesystem.js b/lib/filesystem.js
@@ -110,6 +110,9 @@ FileSystem.prototype.getItem = function(filepath) {
           throw new FSError('EACCES', filepath);
         }
       }
+      if (item instanceof File) {
+        throw new FSError('ENOTDIR', filepath);
+      }
       item = item.getItem(name);
     }
     if (!item) {

diff --git a/test/lib/binding.spec.js b/test/lib/binding.spec.js
@@ -918,6 +918,16 @@ describe('Binding', function() {
         binding.read(fd, buffer, 0, 11, 0);
       });
     });
+
+    it('throws ENOTDIR when trying to open an incorrect path (nested under existing file)', function() {
+      const binding = new Binding(system);
+      assert.throws(function() {
+        binding.open(
+          path.join('mock-dir', 'two.txt', 'bogus-path'),
+          flags('r')
+        );
+      }, 'ENOTDIR');
+    });
   });
 
   describe('#write()', function() {