NAS-131370 / 25.04 / Fix post mount actions execution on system dataset setup #14567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira label ignored, branch name already named after an existing ticket. |
bugclerk
changed the title
|
Are there any concrete steps we can take to improve our CI for these behaviors? |
|
Changes like this make me squirm. This can break failover on our HA. Have you run an entire CI run against an HA system? |
yocalebo
reviewed
Sep 24, 2024
src/middlewared/middlewared/plugins/reporting/netdata_configure.py
Outdated
Show resolved
Hide resolved
@anodos325 i'll push a new integration test for this ✅ |
Qubad786
force-pushed
the
NAS-131190
branch
3 times, most recently
from
e9663bb
to
4a58935
Compare
yocalebo
reviewed
Sep 25, 2024
src/middlewared/middlewared/plugins/reporting/netdata_configure.py
Outdated
Show resolved
Hide resolved
anodos325
reviewed
Sep 25, 2024
src/middlewared/middlewared/plugins/reporting/netdata_configure.py
Outdated
Show resolved
Hide resolved
Qubad786
force-pushed
the
NAS-131190
branch
from
4a58935
to
c297ce0
Compare
anodos325
reviewed
Sep 26, 2024
src/middlewared/middlewared/plugins/reporting/netdata_configure.py
Outdated
Show resolved
Hide resolved
Qubad786
force-pushed
the
NAS-131190
branch
from
c297ce0
to
659c819
Compare
anodos325
reviewed
Sep 26, 2024
Qubad786
force-pushed
the
NAS-131190
branch
from
659c819
to
6753351
Compare
anodos325
approved these changes
Sep 27, 2024
yocalebo
approved these changes
Sep 27, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When system dataset is being migrated, if we have a pool from where it i being migrated - we are temporarily mounting it to another location before it is mounted at it's rightful place so we can copy over data.
However during this transition, we have post mount actions being executed which is not alright and can trigger different failures which in the case i ended up finding this was an issue related to netdata setup not being properly executed.
Solution
Ensure all post mount actions only when the system dataset is mounted at it's rightful place i.e
/var/db/system. Additionally, permissions for ix-state directory in netdata are corrected if any exception occurs on the first time system tries to setup netdata.