Fixe IOS issues #141
Fixe IOS issues #141
Conversation
| .then((value) => { | ||
| completion(STPPaymentStatus.Success, null); | ||
| .then((value: any) => { | ||
| if(!value._native.lastPaymentError || value._native.lastPaymentError == "undefined") { |
There was a problem hiding this comment.
@kefahB @triniwiz I'm having trouble with this change. Every payment fails with the error originating from this line:
Cannot read property 'lastPaymentError' of undefined
In my case, the variable "value" is the result of the promise returned from capturePayment defined in my own code. This is referring to a _native property which my promise doesn't return. Seems like this line of code is supposed to call something else internal to the Stripe pod to get the lastPaymentError?
|
Hi @justinkurtz Strange! before those changes the payment always resolve true even if in the reality is not ! Can you share how do you proceed to capturePayment the payment please ? do you use standard or sheet implementation ? |
|
I think I'm using the standard implementation. I've taken this example and modified it: I see now that the capturePayment method has been changed since I originally adapted it to my project. Previously (in the commented out code) it just made an HTTP post and returned that. Seems as though I need to adapt the new code in capturePayment from that example. |
|
I wonder if we can add a null safe navigation operator to support use cases that don't immediately confirm payment intents or use 3DS. Changing this line to the below would give more flexibility and make it backwards compatible.
|
|
Effectively it is a good idea .. @triniwiz what do you think ? |
|
Sounds good 👌 |
|
Thank you both! I'll create a pull request! ❤️ |
Hi @triniwiz,
I've fixed the issues #134 and #137 and partially the #135, this fixe reduce the number of call but not fixe it definitely