Merge pull request #258 from calebdw/asym_vis

feat: add asymmetric property visibility (PHP 8.4)
tree-sitter · Oct 1, 2024 · 3e96884 · 3e96884
2 parents 74c6b0d + 53ae46a
commit 3e96884
Show file tree

Hide file tree

Showing 8 changed files with 152,324 additions and 151,603 deletions.
diff --git a/common/define-grammar.js b/common/define-grammar.js
@@ -423,10 +423,17 @@ module.exports = function defineGrammar(dialect) {
         ),
       ),
 
-      visibility_modifier: _ => choice(
-        keyword('public'),
-        keyword('protected'),
-        keyword('private'),
+      visibility_modifier: $ => seq(
+        choice(
+          keyword('public'),
+          keyword('protected'),
+          keyword('private'),
+        ),
+        optional(seq(
+          token.immediate('('),
+          alias($.name, $.operation),
+          token.immediate(')'),
+        )),
       ),
 
       function_definition: $ => seq(

diff --git a/php/src/grammar.json b/php/src/grammar.json
diff --git a/php/src/node-types.json b/php/src/node-types.json