Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #186

Merged
merged 16 commits into from
Aug 12, 2023
Merged

Fixes #186

merged 16 commits into from
Aug 12, 2023

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented Aug 12, 2023

Not done w/ this, but leaving it up so I know which issues I fixed already (been 2 weeks)

Supersedes #55
Supersedes #126
Closes #42
Closes #50
Closes #127
Closes #150
Closes #151
Closes #159
Closes #160
Closes #161
Closes #164
Closes #165
Closes #166
Closes #169
Closes #172
Closes #177
Closes #185

@amaanq amaanq marked this pull request as draft August 12, 2023 15:38
@amaanq amaanq force-pushed the fixes branch 8 times, most recently from 8fe769b to 25505ef Compare August 12, 2023 17:46
@amaanq amaanq marked this pull request as ready for review August 12, 2023 18:12
@amaanq amaanq force-pushed the fixes branch 2 times, most recently from 9cbc896 to 3ac494f Compare August 12, 2023 18:21
@amaanq amaanq merged commit 8077be4 into tree-sitter:master Aug 12, 2023
5 checks passed
@carter-canedy
Copy link

You're a legend mate

This was referenced Aug 18, 2023
mournfully added a commit to mournfully/dotfiles that referenced this pull request Aug 21, 2023
[Wrong parsing for `${!#}` · Issue #160 · tree-sitter/tree-sitter-bash](tree-sitter/tree-sitter-bash#160)
> Same problem here, with a similar variable replacement:
> `display="${display%|*}"`
> It makes the syntax broken for the rest of the file

[Fixes by amaanq · Pull Request #186 · tree-sitter/tree-sitter-bash](tree-sitter/tree-sitter-bash#186)

[Drop dependency on `bash-parser` · Issue #72 · webpro/knip](webpro-nl/knip#72)
> Since [email protected] was released the other day I've pulled the
> trigger here as well. Would deserve either a major bump or just a patch
> release. As I think it shouldn't cause friction anywhere I opted for the
> latter (I do expect an occasional issue around arguments w/ quotes here
> and there, let's see).
>
> 🚀 This issue has been resolved in v2.19.6. See Release 2.19.6 for
> release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment