Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.0 compatibility #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drselump14
Copy link

https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

From ruby 3.0, positional and keyword arguments are separated, so we need to use double splat explicitly for these lines

@apotonick
Copy link
Member

Cool, thanks! 💚 Are you happy with the test API so far? Any suggestions from your experience?

@drselump14
Copy link
Author

Hi @apotonick, thanks for approving the PR.
So far the test api works well and I like it, no complaint

@apotonick
Copy link
Member

@yogeshjain999 Could we get CI for this gem, so this would be tested in Ruby 3.x automatically? ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants