-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Fully configurable non dry-matchers endpoint #7
Open
rpbaltazar
wants to merge
11
commits into
trailblazer:master
Choose a base branch
from
rpbaltazar:endpoint-proposal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9b31427
WIP - updated gem file and gemspec config
rpbaltazar 436ebf0
WIP - added rubocop yml
rpbaltazar 1121979
WIP - re-worked endpoint concept
rpbaltazar 9e70574
WIP - writing specs for current endpoint
rpbaltazar b4506be
WIP - added gitignore
rpbaltazar 38df306
WIP - passing all endpoint sepcs
rpbaltazar add981a
WIP - removed byebug require
rpbaltazar 4e05da1
WIP - updated readme to have some description of how it works
rpbaltazar 35a2beb
WIP - added universal matcher
rpbaltazar db464f0
WIP - overwrite the old endpoint with latest production version
rpbaltazar dcdd71c
WIP - added result extender
rpbaltazar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
AllCops: | ||
TargetRubyVersion: 2.3.1 | ||
|
||
Style/StringLiterals: | ||
EnforcedStyle: double_quotes | ||
SupportedStyles: | ||
- single_quotes | ||
- double_quotes | ||
|
||
Metrics/LineLength: | ||
Max: 80 | ||
|
||
Metrics/BlockLength: | ||
CountComments: false # count full line comments? | ||
Max: 25 | ||
ExcludedMethods: [feature, describe, shared_examples_for] | ||
|
||
Style/FrozenStringLiteralComment: | ||
Enabled: false | ||
|
||
Documentation: | ||
Enabled: false | ||
|
||
NumericLiterals: | ||
Exclude: | ||
- 'config/initializers/app_version.rb' | ||
|
||
LambdaCall: | ||
Enabled: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,9 @@ | ||
source 'https://rubygems.org' | ||
source "https://rubygems.org" | ||
|
||
# Specify your gem's dependencies in trailblazer.gemspec | ||
gemspec | ||
|
||
gem "multi_json" | ||
|
||
gem "dry-validation" | ||
gem "minitest-line" | ||
|
||
gem "multi_json" | ||
gem "trailblazer", path: "../trailblazer" | ||
# gem "trailblazer-operation", path: "../operation" | ||
|
||
gem "dry-validation" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
.byebug_history |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In examples and tests you have one more argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the tests are not yet updated to match the final implementation. They were following my mid way solution. There is definitely a little bit of work to be done here for the tests and readme. Was trying to get the general feeling for the actual solution.