Add full_messages_for support #539
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogeshjain999
force-pushed
the
full_messages_for
branch
from
d003c90
to
0999b8a
Compare
seuros
approved these changes
Dec 25, 2023
apotonick
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveModel has added support to pick errors for specific field using
full_messages_formethod.https://api.rubyonrails.org/classes/ActiveModel/Errors.html#method-i-full_messages_for
SimpleForm seems to be using it to generate errors, but gives exception for reform's
errorsobject.This PR adds support to mimic the behaviour.