Use layout.build instead of layout.new #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's brilliant! But no test? 😭 |
|
@apotonick should i place it in builder_test or in layout_test? |
|
@JelF Thanks, into layout test, please. @timoschilling what do you think about this? |
|
@apotonick There is no performance Problem, if you mean this? If the cell don't include |
|
✋ <-- :highfive: |
JelF
force-pushed
the
use-build-instead-of-new-for-layouts
branch
from
1ea5067
to
bbe8eec
Compare
JelF
commented
Nov 2, 2016
|
|
||
| it 'renders special layout if requested' do | ||
| Comment::ShowCell.new(nil, layout: Comment::LayoutCell, context: { special_layout: true }). | ||
| ().must_equal "$layout.erb{Comment::SpecialLayoutCell, $show.erb, {:special_layout=>true} |
There was a problem hiding this comment.
don't sure it's the best way to handle multiline strings. Should i better use heredoc and gsub extra spaces?
in Cell::ViewModel::Layout::External.
Reason: allow layout class to be selected using context.
I.e. builds { |_, context:, **| self::Mobile if context[:mobile] }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use layout.build instead of layout.new in Cell::ViewModel::Layout::External.
Reason: allow layout class to be selected using context.
I.e. builds { |_, context:, **| self::Mobile if context[:mobile] }