Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openai): Update openai dependency and Instrument beta openai SDK calls #2137

Closed
wants to merge 2 commits into from
Closed

fix(openai): Update openai dependency and Instrument beta openai SDK calls #2137

wants to merge 2 commits into from

Conversation

damianr13
Copy link

@damianr13 damianr13 commented Oct 14, 2024 •
edited by nirga
Loading

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

Fixes #1815

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 14, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code testing labels Oct 14, 2024
@nirga nirga changed the title fix(instrumentation): Update openai dependency and Instrument beta openai SDK calls fix(openai): Update openai dependency and Instrument beta openai SDK calls Oct 14, 2024
nirga
nirga reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@nirga nirga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @damianr13, looks good! Mind signing the CLA and fixing the CI errors? (I think we need to guard your change in a try-catch block as it may fail on older OpenAI versions)

@damianr13
Copy link
Author

Thank you for the feedback @nirga, but after I submitted this I found #2111 which seems to do the same thing. That's why I closed my issue as duplicate as well.

Isn't that so?

@nirga
Copy link
Member

nirga commented Oct 15, 2024

You're right! @damianr13
Sorry about that! (or I'm happy since this means we're already resolving this!)

@nirga nirga closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga nirga left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: support structured outputs for OpenAI
3 participants
@damianr13 @CLAassistant @nirga