fix(openai): add structured output instrumentation #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
|
|
nirga
changed the title
I cannot say I fully understand what's going on with semconvs, so let's leave the scope of this PR as it is. |
9dogs
force-pushed
the
structured-output-support
branch
from
1e123c1
to
a15ba8d
Compare
4 tasks
nirga
reviewed
Oct 15, 2024
| @@ -197,6 +197,32 @@ def _instrument(self, **kwargs): | |||
| "Assistants.create", | |||
| assistants_create_wrapper(tracer), | |||
| ) | |||
| wrap_function_wrapper( | |||
There was a problem hiding this comment.
@9dogs we should wrap these in try-except since this may fail on old OpenAI SDK versions (this is why the tests are currently failing)
9dogs
force-pushed
the
structured-output-support
branch
from
63be127
to
40406fb
Compare
nirga
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(instrumentation): ...orfix(instrumentation): ....Fixes #1815. I'm not sure if the response_format span attribute should be added in this PR as well.
Also, the metrics tests are a bit fragile since each executed test adds its metrics to the
reader.get_metrics_data()result, so figuring out what was added is a bit tricky.