Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ollama): tool calling #2059

Merged
merged 3 commits into from
Oct 8, 2024
Merged

feat(ollama): tool calling #2059

merged 3 commits into from
Oct 8, 2024

Conversation

sathvikrav
Copy link
Contributor

@sathvikrav sathvikrav commented Sep 29, 2024 •
edited by nirga
Loading

Fixes #1688

  • [Yes] I have added tests that cover my changes.
  • [No ] If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • [Yes] PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • [NA] (If applicable) I have updated the documentation accordingly.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. python Pull requests that update Python code testing labels Sep 29, 2024
nirga
nirga reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@nirga nirga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sathvikrav, left a small comment!

packages/opentelemetry-instrumentation-ollama/opentelemetry/instrumentation/ollama/__init__.py Outdated
tool_calls = msg.get("tool_calls")
if tool_calls:
for i, tool_call in enumerate(tool_calls):
# if is_openai_v1():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 3, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 5, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Sathvik Ravi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nirga nirga merged commit 9daa0e8 into traceloop:main Oct 8, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga nirga approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Support tool calling for Ollama
3 participants
@sathvikrav @CLAassistant @nirga