fix(langchain): various bugs and edge cases in metric exporting (#2167)

traceloop · Oct 17, 2024 · d101bbb · d101bbb
1 parent 0ba34ba
commit d101bbb
Showing 1 changed file with 3 additions and 18 deletions.
diff --git a/...try-instrumentation-langchain/opentelemetry/instrumentation/langchain/callback_handler.py b/...try-instrumentation-langchain/opentelemetry/instrumentation/langchain/callback_handler.py
@@ -461,21 +461,6 @@ def on_chain_end(
                 ),
             )
 
-        # Record duration
-        duration = time.time() - span_holder.start_time
-        self.duration_histogram.record(
-            duration,
-            attributes={
-                SpanAttributes.LLM_SYSTEM: "Langchain",
-                SpanAttributes.TRACELOOP_SPAN_KIND: span.attributes.get(
-                    SpanAttributes.TRACELOOP_SPAN_KIND
-                ),
-                SpanAttributes.TRACELOOP_ENTITY_NAME: span.attributes.get(
-                    SpanAttributes.TRACELOOP_ENTITY_NAME
-                ),
-            },
-        )
-
         self._end_span(span, run_id)
         if parent_run_id is None:
             context_api.attach(
@@ -585,7 +570,7 @@ def on_llm_end(
                     attributes={
                         SpanAttributes.LLM_SYSTEM: "Langchain",
                         SpanAttributes.LLM_TOKEN_TYPE: "input",
-                        SpanAttributes.LLM_RESPONSE_MODEL: model_name,
+                        SpanAttributes.LLM_RESPONSE_MODEL: model_name or "unknown",
                     },
                 )
 
@@ -595,7 +580,7 @@ def on_llm_end(
                     attributes={
                         SpanAttributes.LLM_SYSTEM: "Langchain",
                         SpanAttributes.LLM_TOKEN_TYPE: "output",
-                        SpanAttributes.LLM_RESPONSE_MODEL: model_name,
+                        SpanAttributes.LLM_RESPONSE_MODEL: model_name or "unknown",
                     },
                 )
 
@@ -608,7 +593,7 @@ def on_llm_end(
             duration,
             attributes={
                 SpanAttributes.LLM_SYSTEM: "Langchain",
-                SpanAttributes.LLM_RESPONSE_MODEL: model_name,
+                SpanAttributes.LLM_RESPONSE_MODEL: model_name or "unknown",
             },
         )