Skip to content

Commit

Permalink
fix(tracing): add missing prompt manager template variables to span a…
Browse files Browse the repository at this point in the history
…ttributes (#140)
  • Loading branch information
galkleinman authored Nov 1, 2023
1 parent cf7a595 commit 113be09
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/traceloop-sdk/traceloop/sdk/prompts/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def render_prompt(self, key: str, **args):
params_dict.pop("mode")

set_prompt_tracing_context(
prompt.key, prompt_version.version, prompt_version.name, prompt_version.hash
prompt.key, prompt_version.version, prompt_version.name, prompt_version.hash, args
)

return params_dict
Expand Down
11 changes: 10 additions & 1 deletion packages/traceloop-sdk/traceloop/sdk/tracing/tracing.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,14 @@ def _span_processor_on_start(self, span, parent_context):
if prompt_version_hash is not None:
span.set_attribute("traceloop.prompt.version_hash", prompt_version_hash)

prompt_template_variables = get_value("prompt_template_variables")
if prompt_version_hash is not None:
print(prompt_template_variables)
for key, value in prompt_template_variables.items():
span.set_attribute(
f"traceloop.prompt.template_variables.{key}", value
)

@staticmethod
def set_static_params(
app_name: str,
Expand Down Expand Up @@ -168,12 +176,13 @@ def set_workflow_name(workflow_name: str) -> None:


def set_prompt_tracing_context(
key: str, version: int, version_name: str, version_hash: str
key: str, version: int, version_name: str, version_hash: str, template_variables: dict
) -> None:
attach(set_value("prompt_key", key))
attach(set_value("prompt_version", version))
attach(set_value("prompt_version_name", version_name))
attach(set_value("prompt_version_hash", version_hash))
attach(set_value("prompt_template_variables", template_variables))


def is_llm_span(span) -> bool:
Expand Down

0 comments on commit 113be09

Please sign in to comment.