Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use path style for bucket endpoint (instead of DNS) [contd. #117] #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kmichailg
Copy link

@kmichailg kmichailg commented Jun 13, 2019

Updated @toehio's pull request as it is stale.

@kmichailg kmichailg changed the title Option to use path style for bucket endpoint (instead of DNS) [!117] Option to use path style for bucket endpoint (instead of DNS) !117 Jun 13, 2019
@kmichailg kmichailg changed the title Option to use path style for bucket endpoint (instead of DNS) !117 Option to use path style for bucket endpoint (instead of DNS) [cont. #117] Jun 13, 2019
@kmichailg kmichailg changed the title Option to use path style for bucket endpoint (instead of DNS) [cont. #117] Option to use path style for bucket endpoint (instead of DNS) [cont. https://github.com/tpyo/amazon-s3-php-class/pull/117] Jun 13, 2019
@kmichailg kmichailg changed the title Option to use path style for bucket endpoint (instead of DNS) [cont. https://github.com/tpyo/amazon-s3-php-class/pull/117] Option to use path style for bucket endpoint (instead of DNS) [cont. #117] Jun 13, 2019
@kmichailg kmichailg changed the title Option to use path style for bucket endpoint (instead of DNS) [cont. #117] Option to use path style for bucket endpoint (instead of DNS) [contd. #117] Jun 13, 2019
@kmichailg
Copy link
Author

@tpyo Any news?

@reina-n
Copy link

reina-n commented Feb 13, 2020

I think to patch on function __dnsBucketName is more easy...

@matheusfrancisco
Copy link

@kmichailg this solves my problem. To everyone looking for a solution when using this lib with localstack AWS s3 this will help u.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants