doc: Fix install.md code blocks #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasFuchsTPM
approved these changes
Jul 19, 2024
AndreasFuchsTPM
requested changes
Jul 19, 2024
|
@mbatra-hunter Thanks for your contribution! To get the DCO check to pass you have to "sign off" your commit, as @AndreasFuchsTPM indicated. # to sign off your last commit
git commit --amend -s
# to replace the old commit with the new one on GitHub
git push -f |
Signed-off-by: M Batra <[email protected]>
|
Thank you! I didn't know if I could amend an existing commit in a PR but your snippet helped. I was going to look into finding out how but didn't get around to it. |
AndreasFuchsTPM
approved these changes
Jul 24, 2024
| * FreeBSD |
There was a problem hiding this comment.
Maybe I'm stupid, but what is the change in this line ?!?
There was a problem hiding this comment.
A newline was either added or removed at the end of the file. It was on accident by me, I was using the GitHub web editor and it didn't show it as a change until after I opened my PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the code blocks in INSTALL.md weren't formatted right, so I fixed it