Remove deprecated value from openssl.conf.sample > default_algorithms #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalvdans
approved these changes
Oct 6, 2024
The option "ECDSA" has been removed since OpenSSL_1_1_0-pre1. Remove it to prevent parser from failing. Signed-off-by: wenxin.leong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
openssl.conf.sample, the valueECDSAhas been removed since OpenSSL_1_1_0-pre1 in this commit.It seems harmless, but if the parser encountered an invalid option, it will exit silently. Meaning, everything come after the line
default_algorithms = RSA,ECDSAare ignored.On top of that, since the tss engine is not using the
ENGINE_set_ECDSA()approach, hence it is safe to remove the value fromdefault_algorithms.This PR is to address issue #260
Signed-off-by: wenxin.leong [email protected]
Resolves #260