Rolling log file writer in new io module #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocketraman
commented
Oct 17, 2024
| watchosX64() | ||
| tvosArm64() | ||
| tvosSimulatorArm64() | ||
| tvosX64() |
There was a problem hiding this comment.
I removed JavaScript from this list, BUT I'm wondering if we should actually leave it. The code should work fine on Node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple implementation to write request logs to files.
Implemented as a rolling system to avoid any one log file becoming too large, and setting an upper bound on device storage. The roll parameters are configurable.
This is useful for debugging user devices in production because apps can contain a feature to send these saved logs to a server for analysis.
Resolves #405 .