double quotes around cocoapods curl header #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #224
Summary
Patches cocoapods dependency manager curl header for use on self-hosted runners with different curl versions.
Fix
Followed @TadeasKriz suggestion of adding double quotes around
["'Accept: application/octet-stream'"]Testing
./gradlew testPASSED./gradlew buildPASSEDWe deployed a 0.3.8-SNAPSHOT from my fork to maven local and used it in our project on our self-hosted runner. The curl command worked and pod lib lint was successful. Please let me know if you have any questions. Thanks!