Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hs-v2: Add deprecation warning for service #1962

Open
wants to merge 3 commits into
base: maint-0.3.5
Choose a base branch
from

Conversation

dgoulet-tor
Copy link
Contributor

If at least one service is configured as a version 2, a log warning is emitted
once and only once.

Closes #40003

Signed-off-by: David Goulet [email protected]

If at least one service is configured as a version 2, a log warning is emitted
once and only once.

Closes #40003

Signed-off-by: David Goulet <[email protected]>
@coveralls
Copy link

coveralls commented Jul 1, 2020

Pull Request Test Coverage Report for Build 9360

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 316 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 60.943%

Files with Coverage Reduction New Missed Lines %
src/feature/nodelist/routerlist.c 316 39.94%
Totals Coverage Status
Change from base Build 9314: 0.003%
Covered Lines: 44594
Relevant Lines: 73173

💛 - Coveralls

@@ -731,6 +747,9 @@ rend_config_service(const config_line_t *line_,
tor_assert(options);
tor_assert(config);

/* We are about to configured a version 2 service. Warn of deprecation. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/configured/configure/g

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixup pushed!

log_warn(LD_REND, "DEPRECATED: Onion service version 2 are deprecated. "
"Please use version 3 which is the default now. "
"Currently, version 2 is planned to be obsolete in "
"the Tor version 0.4.6 stable series.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should link to the tor-dev post or the blog post here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, maybe not ideal to have links hardcoded in our tor codebase as in the link then has to be a super long permalink...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants