Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multiple new certificate events test #302

Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat: add multiple new certificate events test #302

merged 2 commits into from
Sep 25, 2023

Conversation

atanmarko
Copy link
Member

@atanmarko atanmarko commented Sep 12, 2023

Description

Add test with multiple send token events

Fixes TP-691

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko self-assigned this Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.17% ⚠️

Comparison is base (cb2eb7f) 58.22% compared to head (3d47477) 58.05%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   58.22%   58.05%   -0.17%     
==========================================
  Files         230      230              
  Lines       11997    11997              
==========================================
- Hits         6985     6965      -20     
- Misses       5012     5032      +20     
Files Changed Coverage Δ
crates/topos-sequencer-subnet-runtime/src/proxy.rs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atanmarko atanmarko marked this pull request as ready for review September 13, 2023 12:30
@atanmarko atanmarko requested a review from a team as a code owner September 13, 2023 12:30
@atanmarko
Copy link
Member Author

Note: Polygon Edge related PR must be merged for this test to work

@dvdplm
Copy link
Contributor

dvdplm commented Sep 13, 2023

Note: Polygon Edge related PR must be merged for this test to work

Oh. Hmm. How can I run this PR with that PR applied?

@dvdplm
Copy link
Contributor

dvdplm commented Sep 13, 2023

@atanmarko Is this the reason CI is failing?

@atanmarko
Copy link
Member Author

@atanmarko Is this the reason CI is failing?

I had some additional fixes

@atanmarko
Copy link
Member Author

atanmarko commented Sep 13, 2023

Note: Polygon Edge related PR must be merged for this test to work

Oh. Hmm. How can I run this PR with that PR applied?

You can checkout polygon-edge PR referenced, build local docker image:

docker build -t ghcr.io/topos-protocol/polygon-edge:develop --build-arg GITHUB_TOKEN=${GITHUB_TOKEN} -f docker/local-topos/Dockerfile .

Note: GITHUB_TOKEN may not be needed anymore, it was needed when some of our Golang dependencies were private repositories

Then run topos tests:

cd crates/topos-sequencer-subnet-runtime
cargo test 

@atanmarko atanmarko marked this pull request as draft September 13, 2023 21:12
@atanmarko
Copy link
Member Author

Put in a draft mode until Polygon Edge fix is merged

@atanmarko atanmarko force-pushed the feat/TP-691 branch 2 times, most recently from 3a8db4a to bd815cf Compare September 15, 2023 13:01
@atanmarko atanmarko marked this pull request as ready for review September 15, 2023 13:02
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo @Freyskeyd's comments. Left a few nitpicks to fix too.

@atanmarko atanmarko merged commit e648ede into main Sep 25, 2023
19 of 20 checks passed
@atanmarko atanmarko deleted the feat/TP-691 branch September 25, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants