Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #2638 #33

Closed
wants to merge 4 commits into from
Closed

Conversation

gets0ul
Copy link
Collaborator

@gets0ul gets0ul commented Jun 22, 2019

https://github.com/topcoder-platform/community-app/issues/2638

Top Page Navigation should not trigger whole page reload.

@luizrrodrigues luizrrodrigues self-requested a review June 24, 2019 13:08
Copy link
Collaborator

@luizrrodrigues luizrrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gets0ul Cool, all link in main menu working fine without refresh.

But dropdown menu, looks like still reloading the page.

Dropdown menu -> Settings

@gets0ul
Copy link
Collaborator Author

gets0ul commented Jun 24, 2019

@luizrrodrigues Fixed by new commit.
Thanks.

@luizrrodrigues luizrrodrigues self-requested a review June 24, 2019 18:53
@gets0ul
Copy link
Collaborator Author

gets0ul commented Jun 24, 2019

Closed.
New PR is here #37

@gets0ul gets0ul closed this Jun 24, 2019
@gets0ul gets0ul deleted the issue-2638 branch June 24, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants