Drop last in distributed mode (cvg#55)

tompritch30 · Jan 23, 2024 · 8ae966d · 8ae966d
1 parent b28bda7
commit 8ae966d
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/gluefactory/datasets/base_dataset.py b/gluefactory/datasets/base_dataset.py
@@ -161,9 +161,12 @@ def get_data_loader(self, split, shuffle=None, pinned=False, distributed=False):
         except omegaconf.MissingMandatoryValue:
             batch_size = self.conf.batch_size
         num_workers = self.conf.get("num_workers", batch_size)
+        drop_last = True if split == "train" else False
         if distributed:
             shuffle = False
-            sampler = torch.utils.data.distributed.DistributedSampler(dataset)
+            sampler = torch.utils.data.distributed.DistributedSampler(
+                dataset, drop_last=drop_last
+            )
         else:
             sampler = None
             if shuffle is None:
@@ -178,7 +181,7 @@ def get_data_loader(self, split, shuffle=None, pinned=False, distributed=False):
             num_workers=num_workers,
             worker_init_fn=worker_init_fn,
             prefetch_factor=self.conf.prefetch_factor,
-            drop_last=True if split == "train" else False,
+            drop_last=drop_last,
         )
 
     def get_overfit_loader(self, split):