feat: Provide support for batch scraping #2641
hkfgoci-code.yml
on: pull_request
Verify Codebase
1m 21s
Code Quality (R#)
2m 27s
Annotations
1 error, 10 warnings, and 10 notices
|
Code Quality (R#)
Issues found.
|
|
Code Quality (R#):
src/Promitor.Core.Scraping/AzureMonitorScraper.cs#L143
"[PossibleNullReferenceException] Possible 'System.NullReferenceException'" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/AzureMonitorScraper.cs(143,9350)
|
|
Code Quality (R#):
src/Promitor.Core.Scraping/Batching/AzureResourceDefinitionBatching.cs#L3
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/Batching/AzureResourceDefinitionBatching.cs(3,53)
|
|
Code Quality (R#):
src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatchProperties.cs#L98
"[ConvertTypeCheckToNullCheck] Use null check instead of a type check succeeding on any not-null value" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatchProperties.cs(98,4119)
|
|
Code Quality (R#):
src/Promitor.Integrations.AzureMonitor/Configuration/AzureMonitorMetricBatchScrapeConfig.cs#L5
"[RedundantDefaultMemberInitializer] Initializing property by default value is redundant" on /home/runner/work/promitor/promitor/src/Promitor.Integrations.AzureMonitor/Configuration/AzureMonitorMetricBatchScrapeConfig.cs(5,162)
|
|
Code Quality (R#):
src/Promitor.Integrations.AzureMonitor/HttpPipelinePolicies/ModifyOutgoingAzureMonitorRequestsPolicy.cs#L12
"[InvalidXmlDocComment] Cannot resolve symbol 'https'" on /home/runner/work/promitor/promitor/src/Promitor.Integrations.AzureMonitor/HttpPipelinePolicies/ModifyOutgoingAzureMonitorRequestsPolicy.cs(12,366)
|
|
Code Quality (R#):
src/Promitor.Integrations.AzureMonitor/HttpPipelinePolicies/ModifyOutgoingAzureMonitorRequestsPolicy.cs#L12
"[InvalidXmlDocComment] Syntax error" on /home/runner/work/promitor/promitor/src/Promitor.Integrations.AzureMonitor/HttpPipelinePolicies/ModifyOutgoingAzureMonitorRequestsPolicy.cs(12,371)
|
|
Code Quality (R#):
src/Promitor.Integrations.AzureMonitor/HttpPipelinePolicies/ModifyOutgoingAzureMonitorRequestsPolicy.cs#L52
"[AssignNullToNotNullAttribute] Possible 'null' assignment to non-nullable entity" on /home/runner/work/promitor/promitor/src/Promitor.Integrations.AzureMonitor/HttpPipelinePolicies/ModifyOutgoingAzureMonitorRequestsPolicy.cs(52,2414)
|
|
Code Quality (R#):
src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs#L117
"[InconsistentNaming] Name 'scrapeDefinitions5m' does not match rule 'Local variables'. Suggested name is 'scrapeDefinitions5M'." on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs(117,7054)
|
|
Code Quality (R#):
src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs#L121
"[InconsistentNaming] Name 'differentScrapeDefinitions2m' does not match rule 'Local variables'. Suggested name is 'differentScrapeDefinitions2M'." on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs(121,7477)
|
|
Code Quality (R#):
src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs#L176
"[ParameterHidesMember] Parameter 'prometheusMetricDefinition' hides field 'PrometheusMetricDefinition Promitor.Tests.Unit.Core.Scraping.Batching.AzureResourceDefinitionBatchingTests.prometheusMetricDefinition'" on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Core/Scraping/Batching/AzureResourceDefinitionBatchingTests.cs(176,11812)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L12
"[ArrangeNamespaceBody] Convert to file-scoped namespace" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(12,317)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L23
"[MemberCanBeProtected.Global] Method 'CreatePromitorWebHost' can be made protected" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(23,880)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L28
"[SuggestVarOrType_SimpleTypes] Use 'var' (simple types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(28,1260)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L54
"[MemberCanBePrivate.Global] Method 'DetermineHttpPort' can be made private" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(54,2323)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L66
"[SuggestVarOrType_BuiltInTypes] Use 'var' (built-in types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(66,2766)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L79
"[SuggestVarOrType_BuiltInTypes] Use 'var' (built-in types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(79,3190)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L12
"[ArrangeNamespaceBody] Convert to file-scoped namespace" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(12,306)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L18
"[MemberCanBeProtected.Global] Property 'Configuration' can be made protected" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(18,446)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L53
"[VirtualMemberNeverOverridden.Global] Virtual method 'CreateSerilogConfiguration' is never overridden" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(53,1991)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L75
"[VirtualMemberNeverOverridden.Global] Virtual method 'EnrichTelemetry' is never overridden" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(75,3329)
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
test-results
|
310 KB |
|