feat: Provide support for batch scraping #2638
Annotations
1 error, 10 warnings, and 10 notices
|
R# Code Quality
Issues found.
|
|
R# Code Quality:
src/Promitor.Agents.Scraper/Scheduling/ResourcesScrapingJob.cs#L257
"[PossibleNullReferenceException] Possible 'System.NullReferenceException'" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Scraper/Scheduling/ResourcesScrapingJob.cs(257,13929)
|
|
R# Code Quality:
src/Promitor.Core/Extensions/MeasureMetricExtensions.cs#L9
"[InvalidXmlDocComment] Parameter 'measuredMetric' has no matching param tag in the XML comment for Promitor.Core.Extensions.MeasuredMetricExtensions.WithResourceIdAssociation (but other parameters do)" on /home/runner/work/promitor/promitor/src/Promitor.Core/Extensions/MeasureMetricExtensions.cs(9,401)
|
|
R# Code Quality:
src/Promitor.Core.Scraping/AzureMonitorScraper.cs#L143
"[PossibleNullReferenceException] Possible 'System.NullReferenceException'" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/AzureMonitorScraper.cs(143,9350)
|
|
R# Code Quality:
src/Promitor.Core.Scraping/Batching/AzureResourceDefinitionBatching.cs#L30
"[UnusedParameter.Local] Parameter 'cancellationToken' is never used" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/Batching/AzureResourceDefinitionBatching.cs(30,1861)
|
|
R# Code Quality:
src/Promitor.Core.Scraping/Configuration/Model/Metrics/BatchScrapeDefinition.cs#L1
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/Configuration/Model/Metrics/BatchScrapeDefinition.cs
|
|
R# Code Quality:
src/Promitor.Core.Scraping/Configuration/Model/Metrics/BatchScrapeDefinition.cs#L36
"[MemberInitializerValueIgnored] Property initializer value ignored during initialization" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/Configuration/Model/Metrics/BatchScrapeDefinition.cs(36,1858)
|
|
R# Code Quality:
src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatch.cs#L86
"[InvalidXmlDocComment] XML element is not closed" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatch.cs(86,3544)
|
|
R# Code Quality:
src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatch.cs#L86
"[InvalidXmlDocComment] XML element is not closed" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatch.cs(86,3571)
|
|
R# Code Quality:
src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatch.cs#L86
"[InvalidXmlDocComment] XML element is not closed" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatch.cs(86,3588)
|
|
R# Code Quality:
src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatch.cs#L86
"[InvalidXmlDocComment] XML element is not closed" on /home/runner/work/promitor/promitor/src/Promitor.Core.Scraping/Configuration/Model/Metrics/ScrapeDefinitionBatch.cs(86,3603)
|
|
R# Code Quality:
src/Promitor.Agents.Core/AgentProgram.cs#L12
"[ArrangeNamespaceBody] Convert to file-scoped namespace" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(12,317)
|
|
R# Code Quality:
src/Promitor.Agents.Core/AgentProgram.cs#L23
"[MemberCanBeProtected.Global] Method 'CreatePromitorWebHost' can be made protected" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(23,880)
|
|
R# Code Quality:
src/Promitor.Agents.Core/AgentProgram.cs#L28
"[SuggestVarOrType_SimpleTypes] Use 'var' (simple types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(28,1260)
|
|
R# Code Quality:
src/Promitor.Agents.Core/AgentProgram.cs#L54
"[MemberCanBePrivate.Global] Method 'DetermineHttpPort' can be made private" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(54,2323)
|
|
R# Code Quality:
src/Promitor.Agents.Core/AgentProgram.cs#L66
"[SuggestVarOrType_BuiltInTypes] Use 'var' (built-in types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(66,2766)
|
|
R# Code Quality:
src/Promitor.Agents.Core/AgentProgram.cs#L79
"[SuggestVarOrType_BuiltInTypes] Use 'var' (built-in types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(79,3190)
|
|
R# Code Quality:
src/Promitor.Agents.Core/AgentStartup.cs#L12
"[ArrangeNamespaceBody] Convert to file-scoped namespace" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(12,306)
|
|
R# Code Quality:
src/Promitor.Agents.Core/AgentStartup.cs#L18
"[MemberCanBeProtected.Global] Property 'Configuration' can be made protected" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(18,446)
|
|
R# Code Quality:
src/Promitor.Agents.Core/AgentStartup.cs#L53
"[VirtualMemberNeverOverridden.Global] Virtual method 'CreateSerilogConfiguration' is never overridden" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(53,1991)
|
|
R# Code Quality:
src/Promitor.Agents.Core/AgentStartup.cs#L75
"[VirtualMemberNeverOverridden.Global] Virtual method 'EnrichTelemetry' is never overridden" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(75,3329)
|
Loading