Changed Error color to #ff3333 red, better visibility #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonlevinsohn
commented
Jun 5, 2014
jasonlevinsohn
commented
- Started using this color and really like it, but the error color when checking validation or syntax is very faint.
- Error's should stand out
- Thought others might share the same sentiment
|
Can you post a before/after screenshot? |
|
Sure.
|
|
@jasonlevinsohn Could you also add I would like to see this change merged. The current error color is close to useless. |
| @@ -161,7 +161,7 @@ if &t_Co > 255 | |||
| hi DiffText ctermbg=102 cterm=bold | |||
|
|
|||
| hi Directory ctermfg=118 cterm=bold | |||
| hi Error ctermfg=219 ctermbg=89 | |||
| hi Error ctermfg=219 ctermbg=196 | |||
There was a problem hiding this comment.
@justinmk The foreground color I think is fine. I changed the background in the 256-color section to the closest color I could find.
There was a problem hiding this comment.
ctermfg=219 is a bit muddled, I would vote to just go for a full ctermfg=255.
| @@ -161,7 +161,7 @@ if &t_Co > 255 | |||
| hi DiffText ctermbg=102 cterm=bold | |||
|
|
|||
| hi Directory ctermfg=118 cterm=bold | |||
| hi Error ctermfg=219 ctermbg=89 | |||
| hi Error ctermfg=255 ctermbg=196 | |||
There was a problem hiding this comment.
@justinmk I couldn't get my editor to display in 256 color so I'm not able to test. updated to ctermfg=255
edentsai
added a commit
to edentsai/extended-molokai
that referenced
this pull request
Oct 2, 2015
Changed Error color to #ff3333 red, better visibility
edentsai
added a commit
to edentsai/extended-molokai
that referenced
this pull request
Oct 4, 2015
Changed Error color to #ff3333 red, better visibility
edentsai
added a commit
to edentsai/extended-molokai
that referenced
this pull request
Oct 4, 2015
Changed Error color to #ff3333 red, better visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.