Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls13-ecdsa-support: verify that all signature algs work #610

Merged
merged 1 commit into from
Nov 15, 2019
Merged

tls13-ecdsa-support: verify that all signature algs work #610

merged 1 commit into from
Nov 15, 2019

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented Nov 5, 2019 •
edited
Loading

Description

make the test suite test new features in tlslite-ng

Motivation and Context

after tlsfuzzer/tlslite-ng#196 is merged the server can have multiple certificates
configured, make sure that it selects good certs for given
key types

Checklist

  • I have read the CONTRIBUTING.md document and my PR follows change requirements therein
  • the changes are also reflected in documentation and code comments
  • all new and existing tests pass (see Travis CI results)
  • test script checklist was followed for new scripts
  • new test script added to tlslite-ng.json and tlslite-ng-random-subset.json
  • new and modified scripts were ran against popular TLS implementations:
    • n/a - no changes to test scripts
  • required version of tlslite-ng updated in requirements.txt and README.md

This change is Reviewable

@tomato42 tomato42 added blocked waiting for some other issue to be resolved new test script will require creation of a new connection script labels Nov 6, 2019
@tomato42 tomato42 removed the blocked waiting for some other issue to be resolved label Nov 13, 2019
@tomato42 tomato42 self-assigned this Nov 13, 2019
@tomato42
tls13-ecdsa-support: verify that all signature algs work
758be42 
after #196 is merged the server can have multiple certificates
configured, make sure that it selects good certs for given
key types
@tomato42 tomato42 requested a review from ep69 November 15, 2019 13:17
ep69
ep69 approved these changes Nov 15, 2019
View reviewed changes
Copy link
Collaborator

@ep69 ep69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@tomato42 tomato42 merged commit fa164a6 into master Nov 15, 2019
@tomato42 tomato42 deleted the multi-ecdsa branch November 15, 2019 16:31
@tomato42
Copy link
Member Author

@ep69 thanks for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ep69 ep69 ep69 approved these changes

Assignees

@tomato42 tomato42

Labels
new test script will require creation of a new connection script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomato42 @ep69