Skip to content

Merge pull request #51 from szabgab/patch-1 #325

Merge pull request #51 from szabgab/patch-1

Merge pull request #51 from szabgab/patch-1 #325

GitHub Actions / clippy succeeded Aug 1, 2023 in 0s

clippy

19 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 19
Note 0
Help 0

Versions

  • rustc 1.73.0-nightly (db7ff98a7 2023-07-31)
  • cargo 1.73.0-nightly (c91a693e7 2023-07-31)
  • clippy 0.1.73 (db7ff98 2023-07-31)

Annotations

Check warning on line 218 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
   --> src/memory.rs:218:9
    |
218 |     cr: &'a mut OCamlRuntime,
    |         ^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 200 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
   --> src/memory.rs:200:34
    |
200 | pub fn alloc_box<A: 'static>(cr: &mut OCamlRuntime, data: A) -> OCaml<DynBox<A>> {
    |                                  ^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 152 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
   --> src/memory.rs:152:9
    |
152 |     cr: &mut OCamlRuntime,
    |         ^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 138 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
   --> src/memory.rs:138:9
    |
138 |     cr: &'a mut OCamlRuntime,
    |         ^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
    |
    = warning: changing this function will impact semver compatibility
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 129 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
   --> src/memory.rs:129:34
    |
129 | pub unsafe fn alloc_tuple<T>(cr: &mut OCamlRuntime, size: usize) -> OCaml<T> {
    |                                  ^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
    |
    = warning: changing this function will impact semver compatibility
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 118 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
   --> src/memory.rs:118:9
    |
118 |     cr: &'a mut OCamlRuntime,
    |         ^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 117 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'b

warning: the following explicit lifetimes could be elided: 'b
   --> src/memory.rs:117:24
    |
117 | pub fn alloc_error<'a, 'b, A, Err>(
    |                        ^^
118 |     cr: &'a mut OCamlRuntime,
119 |     err: OCamlRef<'b, Err>,
    |                   ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
117 ~ pub fn alloc_error<'a, A, Err>(
118 |     cr: &'a mut OCamlRuntime,
119 ~     err: OCamlRef<'_, Err>,
    |

Check warning on line 107 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
   --> src/memory.rs:107:9
    |
107 |     cr: &'a mut OCamlRuntime,
    |         ^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 106 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'b

warning: the following explicit lifetimes could be elided: 'b
   --> src/memory.rs:106:21
    |
106 | pub fn alloc_ok<'a, 'b, A, Err>(
    |                     ^^
107 |     cr: &'a mut OCamlRuntime,
108 |     value: OCamlRef<'b, A>,
    |                     ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
106 ~ pub fn alloc_ok<'a, A, Err>(
107 |     cr: &'a mut OCamlRuntime,
108 ~     value: OCamlRef<'_, A>,
    |

Check warning on line 96 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
  --> src/memory.rs:96:9
   |
96 |     cr: &'a mut OCamlRuntime,
   |         ^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 95 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'b

warning: the following explicit lifetimes could be elided: 'b
  --> src/memory.rs:95:23
   |
95 | pub fn alloc_some<'a, 'b, A>(
   |                       ^^
96 |     cr: &'a mut OCamlRuntime,
97 |     value: OCamlRef<'b, A>,
   |                     ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
   |
95 ~ pub fn alloc_some<'a, A>(
96 |     cr: &'a mut OCamlRuntime,
97 ~     value: OCamlRef<'_, A>,
   |

Check warning on line 87 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
  --> src/memory.rs:87:25
   |
87 | pub fn alloc_double(cr: &mut OCamlRuntime, d: f64) -> OCaml<OCamlFloat> {
   |                         ^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 83 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
  --> src/memory.rs:83:24
   |
83 | pub fn alloc_int64(cr: &mut OCamlRuntime, i: i64) -> OCaml<OCamlInt64> {
   |                        ^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 79 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
  --> src/memory.rs:79:24
   |
79 | pub fn alloc_int32(cr: &mut OCamlRuntime, i: i32) -> OCaml<OCamlInt32> {
   |                        ^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 69 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
  --> src/memory.rs:69:29
   |
69 | pub fn alloc_string<'a>(cr: &'a mut OCamlRuntime, s: &str) -> OCaml<'a, String> {
   |                             ^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 59 in src/memory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
  --> src/memory.rs:59:28
   |
59 | pub fn alloc_bytes<'a>(cr: &'a mut OCamlRuntime, s: &[u8]) -> OCaml<'a, OCamlBytes> {
   |                            ^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 22 in src/conv/to_ocaml.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for unsafe trait missing `# Safety` section

warning: docs for unsafe trait missing `# Safety` section
  --> src/conv/to_ocaml.rs:22:1
   |
22 | pub unsafe trait ToOCaml<T> {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc

Check warning on line 10 in src/conv/from_ocaml.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for unsafe trait missing `# Safety` section

warning: docs for unsafe trait missing `# Safety` section
  --> src/conv/from_ocaml.rs:10:1
   |
10 | pub unsafe trait FromOCaml<T> {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
   = note: `#[warn(clippy::missing_safety_doc)]` on by default

Check warning on line 70 in src/closure.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
  --> src/closure.rs:70:13
   |
70 |         cr: &'a mut OCamlRuntime,
   |             ^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&OCamlRuntime`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
   = note: `#[warn(clippy::needless_pass_by_ref_mut)]` on by default