Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dependency maintenance october 2023 #5

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Oct 1, 2023

Bump some deps, defaults to Node 20

@socket-security
Copy link

socket-security bot commented Oct 1, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
typescript 5.2.2 filesystem +0 40.6 MB typescript-bot
c8 7.13.0...8.0.1 None +0/-0 38.6 kB oss-bot
eslint-config-prettier 8.7.0...9.0.0 environment +1/-1 2.98 MB lydell
@commitlint/cli 17.4.4...17.7.2 None +2/-1 40.7 MB escapedcat
eslint 8.36.0...8.50.0 None +0/-0 2.96 MB eslintbot

🚮 Removed packages: [email protected]

@aldy505
Copy link
Member Author

aldy505 commented Oct 1, 2023

I don't know why but uvu hangs forever now.

@talentlessguy Is it okay if I move to vitest?

@talentlessguy
Copy link
Member

I don't know why but uvu hangs forever now.

@talentlessguy Is it okay if I move to vitest?

if tests hang it's not uvu I think, maybe some promise never resolves or something like that IMO

@aldy505
Copy link
Member Author

aldy505 commented Oct 1, 2023

I don't know why but uvu hangs forever now.
@talentlessguy Is it okay if I move to vitest?

if tests hang it's not uvu I think, maybe some promise never resolves or something like that IMO

It turns out, upgrading @tinyhttp/app from 2.0.29 to 2.2.0 causes the issue. Let me find out which version started this issue.

@talentlessguy
Copy link
Member

I don't know why but uvu hangs forever now.
@talentlessguy Is it okay if I move to vitest?

if tests hang it's not uvu I think, maybe some promise never resolves or something like that IMO

It turns out, upgrading @tinyhttp/app from 2.0.29 to 2.2.0 causes the issue. Let me find out which version started this issue.

Might be a bug in tinyhttp, if you catch it please file an issue on the tinyhttp repo

@aldy505
Copy link
Member Author

aldy505 commented Oct 1, 2023

Found it, started on 2.0.33, the in-between version (2.0.31 and 2.0.32) works fine.

@talentlessguy
Copy link
Member

Also a question — why bump CI to latest Node? I think it instead should be using the oldest supported version

the only problem though is that latest pnpm supports onl Node 18+ afaik

@aldy505
Copy link
Member Author

aldy505 commented Oct 1, 2023

Also a question — why bump CI to latest Node? I think it instead should be using the oldest supported version

the only problem though is that latest pnpm supports onl Node 18+ afaik

I actually wanted to use a matrix version for Node, yet I don't know how would Coveralls handles that. It should be running Node 18 and Node 20 though.

@talentlessguy
Copy link
Member

Also a question — why bump CI to latest Node? I think it instead should be using the oldest supported version

the only problem though is that latest pnpm supports onl Node 18+ afaik

I actually wanted to use a matrix version for Node, yet I don't know how would Coveralls handles that. It should be running Node 18 and Node 20 though.

I think just having Node 18 for CI is okay (Node 20 doesn't contain any breaking changes that could break Malibu tmk)

@talentlessguy
Copy link
Member

Until the problem is resolved, let's stick to 2.0.32 of tinyhttp

@talentlessguy talentlessguy merged commit 78e2f8c into master Nov 5, 2023
5 checks passed
@talentlessguy talentlessguy deleted the chore/maintenance-october-2023 branch November 5, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants