-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uc8151 Improvements DrawBitmap and DrawBuffer #680
base: dev
Are you sure you want to change the base?
Conversation
@conejoninja please rebase against latest |
interface and DrawBuffer to set directly the buffer. Build on top of tinygo-org#679
34ef366
to
5f2645f
Compare
Probably the first time I rebase locally, hope I didn't screw up. |
That was perfect. 👍 |
@@ -201,6 +201,31 @@ func (d *Device) DrawBitmap(x, y int16, bitmap pixel.Image[pixel.Monochrome]) er | |||
return nil | |||
} | |||
|
|||
// DrawBuffer copies the buffer directly to the screen at the given coordinates (no rotation taken into account). X coordinate and width need to be a multiple of 8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(no rotation taken into account)
That seems is a possible issue, since most of the time with this screen we operate at 270 degrees rotation.
|
|
Perhaps you would like to improve the implementation of |
Not sure if possible or worthy. |
No description provided.