Fix: If "opts.focal" - calculate coordinates taking into account the planned Scale, and not just the calculated Scale #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…planned Scale, and not just the calculated Scale (panzoom.ts)
IgorA100
added a commit
to IgorA100/zoneminder
that referenced
this pull request
Jun 17, 2024
…planned Scale, and not just the calculated Scale (jquery.panzoom.js) I created a PR in the author's repository, but there is no feedback yet. timmywil/panzoom#669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please review the guidelines for contributing to this repository.
yarn testagainst my changes and tests pass.test/unit/or a new or altered demo indemo/.yarn docs), or no docs changes are needed.Description
The focal point zooming coordinates must be calculated taking into account both the calculated Scale and the planned Scale.
Fixes: #668