Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Shadow DOM parents #646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dermotduffy
Copy link

PR Checklist

Please review the guidelines for contributing to this repository.

  • I am requesting to pull a topic/feature/bugfix branch (right side). In other words, not main.
  • I have run yarn test against my changes and tests pass.
  • I have added tests to prove my fix is effective or my feature works. This can be done in the form of unit tests in test/unit/ or a new or altered demo in demo/.
  • I have added or edited necessary types and generated documentation (yarn docs), or no docs changes are needed.

Description

Add support for the parent element being a Shadow Root host. Right now, this library will support elements in Shadow DOM, but not if the parent element is the shadow root host (i.e. use of this library at the top-level of a web component).

Also includes very minor typing fixes/clarifications.

Fixes: #

@dermotduffy
Copy link
Author

@timmywil Gentle ping -- any thoughts on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant