Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove NeutronMsg + wasm bindings and use protobuf directly #71

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

keyleu
Copy link
Contributor

@keyleu keyleu commented Oct 15, 2024

Move away from NeutronMsg and wasm bindings which ties the authorization contract to Neutron. With this change we can deploy the authorization contract to any tokenfactory chain and move away from what Neutron is deprecating at the moment.

Note: can't use neutron-std or latest commit of neutron-sdk because they inject cosmwasm_2_0 feature and we can't test with it atm.
Once we can, we can replace neutron-sdk + cosmos-sdk-proto for neutron-std and Stargate for AnyMsg, added TODOs there. Code would be the same.

@keyleu keyleu requested review from Art3miX, bekauz and stiiifff and removed request for Art3miX and bekauz October 15, 2024 11:12
Copy link
Contributor

@bekauz bekauz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me. just one thing with regards to the future neutron crates version, would we be able to use it on osmosis?

@keyleu
Copy link
Contributor Author

keyleu commented Oct 15, 2024

makes sense to me. just one thing with regards to the future neutron crates version, would we be able to use it on osmosis?

yes, they are using the same type_url. Just requires Osmosis to also have cosmwasm_2_0 feature working (which current version hasn't but there is a PR to make it work)

@keyleu keyleu merged commit 3e8eb90 into main Oct 15, 2024
4 checks passed
@keyleu keyleu deleted the use-protos branch October 15, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants