2 party POL Astroport Single domain (Neutron) e2e test with manager #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stiiifff
reviewed
Oct 17, 2024
| assert!(tokenfactory_token_balance.len() == 1); | ||
| assert!(neutron_balance.len() == 1); | ||
| assert!(tokenfactory_token_balance[0].denom == token); | ||
| assert!(neutron_balance[0].denom == *NTRN_DENOM); |
There was a problem hiding this comment.
Why not verify the balance amounts ?
There was a problem hiding this comment.
because I don't know them basically, they've gone through the pool, including a swap, with some small slippage for both the liquidity providing and the internal swap and they are not exactly the same as the input amounts. I'm just checking that flow is correctly executed and that the tokens arrived at the destination (not how astroport works)
|
It's really amazing to see all the Valence components coming together in this e2e test ! 🥳🚀 |
stiiifff
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the e2e test for the 2 party POL single domain using the manager.
Some services were using ActionsMsgs and others ActionMsgs, so changed them all to be the same (ActionMsgs).
Also added test to CI.