Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBC transfer service - WIP #62

Merged
merged 30 commits into from
Oct 18, 2024
Merged

IBC transfer service - WIP #62

merged 30 commits into from
Oct 18, 2024

Conversation

stiiifff
Copy link
Collaborator

@stiiifff stiiifff commented Oct 11, 2024 •
edited
Loading

Initial IBC transfer service implementation.

  • Only works from Neutron to other chain for now (uses Neutron SDK -specific types & messages to perform the IBC transfer)
  • Fixed amount specified in config; effective amount transferred is configured amount minus IBC fees.
  • Supports native tokens & CW20 tokens (for chains supporting a custom port for CW20 transfers).
  • RefundDust operation allows to refund dust balance left on service back to the input account.
  • E2E test with local-ic for Neutron->Juno and Juno->Neutron ✅

Todo:

  • Add unit tests to verify validation logic
  • Support non-Neutron CosmWasm chain
  •  Add support for specifying a PFM map
  •  Add README

keyleu
keyleu requested changes Oct 11, 2024
View reviewed changes
.github/workflows/check-ci.yml Outdated Show resolved Hide resolved
packages/ibc-utils/src/state.rs Outdated Show resolved Hide resolved
contracts/services/ibc-transfer/src/contract.rs Outdated Show resolved Hide resolved
contracts/services/ibc-transfer/src/contract.rs Outdated Show resolved Hide resolved
local-interchaintest/examples/ibc_transfer_juno_ntrn.rs Outdated Show resolved Hide resolved
local-interchaintest/examples/ibc_transfer_juno_ntrn.rs Outdated Show resolved Hide resolved
local-interchaintest/examples/ibc_transfer_juno_ntrn.rs Outdated Show resolved Hide resolved
local-interchaintest/examples/ibc_transfer_ntrn_juno.rs Outdated Show resolved Hide resolved
local-interchaintest/examples/ibc_transfer_ntrn_juno.rs Outdated Show resolved Hide resolved
local-interchaintest/examples/ibc_transfer_ntrn_juno.rs Show resolved Hide resolved
@stiiifff stiiifff mentioned this pull request Oct 15, 2024
Closed
@stiiifff
Add validations & tests for generic service, support for full amount.
a77bf39
@stiiifff
Neutron IBC Transfer service
6a879a0
@stiiifff
Update local-ic test to also test a FullAmount transfer (after updati…
5ef6c20 
…ng config)
@stiiifff
cargo fmt
d9f2862
@stiiifff
Add support for PFM in Neutron IBC transfer service
06344ab
@stiiifff
cargo fmt
012eaa9
@stiiifff
Update CI actions
2158c3f
@stiiifff
Add support for PFM in Generic IBC transfer service
a958a04
@stiiifff
Fix e2e PFM test names
055e5b7
@stiiifff
Merge branch 'main' into sde/ibc-transfer-service
0f426cb
@stiiifff
Revert "Add support for PFM in Generic IBC transfer service"
b0e4dfa 
This reverts commit a958a04.
@stiiifff
Merge branch 'main' into sde/ibc-transfer-service
b61d26a
@stiiifff
Fix build
5b53dfe
@stiiifff
Add README files; add validation & test for denom_to_pfm_map (current…
a371904 
…ly unsupported in Generic IBC Transfer service.
@stiiifff
Fix Neutron IBC Transfer service README
3ab0115
keyleu
keyleu reviewed Oct 18, 2024
View reviewed changes
contracts/services/generic-ibc-transfer/README.md Show resolved Hide resolved
contracts/services/generic-ibc-transfer/src/msg.rs Outdated Show resolved Hide resolved
contracts/services/neutron-ibc-transfer/README.md Show resolved Hide resolved
contracts/services/generic-ibc-transfer/src/msg.rs Outdated Show resolved Hide resolved
contracts/services/neutron-ibc-transfer/src/contract.rs Outdated Show resolved Hide resolved
local-interchaintest/examples/ibc_transfer_juno_ntrn.rs Show resolved Hide resolved
packages/ibc-utils/src/neutron.rs Show resolved Hide resolved
packages/ibc-utils/src/state.rs Outdated Show resolved Hide resolved
packages/ibc-utils/src/state.rs Outdated Show resolved Hide resolved
@keyleu keyleu self-requested a review October 18, 2024 21:40
@stiiifff stiiifff merged commit 0bb2a9e into main Oct 18, 2024
8 checks passed
@stiiifff stiiifff deleted the sde/ibc-transfer-service branch October 18, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyleu keyleu keyleu approved these changes

@Art3miX Art3miX Awaiting requested review from Art3miX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stiiifff @Art3miX @keyleu