Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ServiceAccountType for account addresses in ServiceConfig structs #53

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Use ServiceAccountType for account addresses in ServiceConfig structs #53

merged 2 commits into from
Oct 4, 2024

Conversation

stiiifff
Copy link
Collaborator

@stiiifff stiiifff commented Oct 4, 2024

No description provided.

keyleu
keyleu approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@keyleu keyleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, will conflict with current token-swap e2e PR so let's merge this one first

@stiiifff stiiifff merged commit 18df7fd into main Oct 4, 2024
3 checks passed
@stiiifff stiiifff deleted the sde/use-serviceaccounttype-in-serviceconfig branch October 4, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyleu keyleu keyleu approved these changes

@Art3miX Art3miX Awaiting requested review from Art3miX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stiiifff @keyleu