client: undo set read-timeout for failed GetNameVersion #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undo temporary read-timeout in
GetNameVersion()
. (Note that code in this function does not take into account the possibility for another read-timeout already set. This fix only makesGetNameVersion()
behave as expected under the same assumptions already present.)update: you could consider calling
panic
on the error oftk.conn.SetReadTimeout
. The only error possible seems to be for invalid values, and those are handled already. The panic would never trigger, but it would alert you in case the serial-port API changes unexpectedly.SetReadTimeout
,panic
in case of error attk.conn.SetReadTimeout
,GetNameVersion
, calldefer SetReadTimeout(0)
immediately afterSetReadTimeout(2)
,SetReadTimeout(0)
asdefer
already handles every exit,