Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix makefile lines and tee exit status problem #269

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix makefile lines and tee exit status problem #269

merged 1 commit into from
Oct 9, 2024

Conversation

jthornblad
Copy link
Contributor

@jthornblad jthornblad commented Oct 7, 2024 •
edited by dehanj
Loading

Description

  • Break long lines and use tab to indent
  • Remove use of "tee" since it messes up the return status
  • Remove the generated application_fpga_par.json if nextpnr-ice40 fails on timing.
  • Change log file ending from .log to .txt
  • Fix some spacing

Type of change

Please tick any that are relevant to this PR and remove any that aren't.

  • Bugfix (non breaking change which resolve an issue)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have added a "Co-authored-by: x" if several people contributed, either pair programming or by squashing commits from different authors.
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)
  • QEMU is updated to reflect changes

dehanj
dehanj reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@dehanj dehanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks good.

Is it tested on target to see if anything obvious isn't messed up?
Does not look like it according to the submission checklist.

hw/application_fpga/Makefile Outdated Show resolved Hide resolved
@jthornblad
Fix makefile lines and tee exit status problem
0ea0eeb 
* Break long lines and use tab to indent
* Remove use of "tee" since it messes up the return status
* Remove the generated application_fpga_par.json if nextpnr-ice40 fails
  on timing.
* Change log file ending from .log to .txt
* Fix some spacing
@dehanj dehanj merged commit 0ea0eeb into main Oct 9, 2024
5 checks passed
@dehanj dehanj deleted the fix_makefile branch October 9, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dehanj dehanj dehanj approved these changes

@mchack-work mchack-work Awaiting requested review from mchack-work

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jthornblad @dehanj